Merge pull request #1102 from hdelan/adapter-batch1

[HIP] Adapter PR batch

Author: kbenzie

source/adapters/hip/context.hpp

@@ -112,45 +112,25 @@ struct ur_context_handle_t_ {
 };
 
 namespace {
-/// RAII type to guarantee recovering original HIP context
-/// Scoped context is used across all UR HIP plugin implementation
-/// to activate the UR Context on the current thread, matching the
-/// HIP driver semantics where the context used for the HIP Driver
-/// API is the one active on the thread.
-/// The implementation tries to avoid replacing the hipCtx_t if it cans
+/// Scoped context is used across all UR HIP plugin implementation to activate
+/// the native Context on the current thread. The ScopedContext does not
+/// reinstate the previous context as all operations in the hip adapter that
+/// require an active context, set the active context and don't rely on context
+/// reinstation
 class ScopedContext {
-  hipCtx_t Original;
-  bool NeedToRecover;
-
 public:
-  ScopedContext(ur_device_handle_t hDevice) : NeedToRecover{false} {
+  ScopedContext(ur_device_handle_t hDevice) {
+    hipCtx_t Original{};
 
     if (!hDevice) {
       throw UR_RESULT_ERROR_INVALID_DEVICE;
     }
 
-    // FIXME when multi device context are supported in HIP adapter
     hipCtx_t Desired = hDevice->getNativeContext();
     UR_CHECK_ERROR(hipCtxGetCurrent(&Original));
     if (Original != Desired) {
       // Sets the desired context as the active one for the thread
       UR_CHECK_ERROR(hipCtxSetCurrent(Desired));
-      if (Original == nullptr) {
-        // No context is installed on the current thread
-        // This is the most common case. We can activate the context in the
-        // thread and leave it there until all the UR context referring to the
-        // same underlying HIP context are destroyed. This emulates
-        // the behaviour of the HIP runtime api, and avoids costly context
-        // switches. No action is required on this side of the if.
-      } else {
-        NeedToRecover = true;
-      }
-    }
-  }
-
-  ~ScopedContext() {
-    if (NeedToRecover) {
-      UR_CHECK_ERROR(hipCtxSetCurrent(Original));
     }
   }
 };

source/adapters/hip/ur_interface_loader.cpp

@@ -304,6 +304,22 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetUsmP2PExpProcAddrTable(
   return retVal;
 }
 
+// TODO: Implement
+UR_DLLEXPORT ur_result_t UR_APICALL urGetBindlessImagesExpProcAddrTable(
+    ur_api_version_t, ur_bindless_images_exp_dditable_t *) {
+  // This needs to return UR_RESULT_SUCCESS or else the platform can't be
+  // initialized
+  return UR_RESULT_SUCCESS;
+}
+
+// TODO: Implement
+UR_DLLEXPORT ur_result_t UR_APICALL
+urGetUSMExpProcAddrTable(ur_api_version_t, ur_usm_exp_dditable_t *) {
+  // This needs to return UR_RESULT_SUCCESS or else the platform can't be
+  // initialized
+  return UR_RESULT_SUCCESS;
+}
+
 UR_DLLEXPORT ur_result_t UR_APICALL urGetVirtualMemProcAddrTable(
     ur_api_version_t version, ///< [in] API version requested
     ur_virtual_mem_dditable_t