Add support for command-buffer kernel updates #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
EwanC
reviewed
Aug 5, 2024
EwanC
reviewed
Aug 6, 2024
Bensuo
approved these changes
Aug 7, 2024
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update
branch
4 times, most recently
from
bf49ae5 to
c06abd1
Compare
EwanC
reviewed
Sep 5, 2024
test/conformance/exp_command_buffer/update/kernel_handle_update.cpp
Outdated
Show resolved
Hide resolved
EwanC
changed the title
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update
branch
2 times, most recently
from
9997afa to
f478846
Compare
fabiomestre
commented
Sep 11, 2024
Bensuo
approved these changes
Sep 11, 2024
EwanC
reviewed
Sep 16, 2024
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update
branch
4 times, most recently
from
5ddaec0 to
59e890c
Compare
EwanC
approved these changes
Sep 18, 2024
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update
branch
2 times, most recently
from
7735328 to
52f534d
Compare
Bensuo
approved these changes
Sep 18, 2024
Contributor
Author
|
This PR should be ready for reviewing: |
PietroGhg
approved these changes
Sep 23, 2024
Contributor
PietroGhg
left a comment
PietroGhg
left a comment
There was a problem hiding this comment.
Native CPU lgtm, thank you
aarongreig
reviewed
Sep 23, 2024
aarongreig
approved these changes
Sep 23, 2024
nrspruit
approved these changes
Sep 25, 2024
- Updates the specification to add support for command-buffer kernel handle updates.
- Adds new UR tests for this feature.
- Adds an implementation for the Cuda and Hip adapters.
- Changes the UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP enum to a new UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP which uses a bitfield instead of a boolean.
- Changes the spec for urCommandBufferUpdateKernelLaunchExp and ur_exp_command_buffer_update_kernel_launch_desc_t to make it more intuitive with less complicated errors codes:
- Passing a non-nullptr local work-group will now always update the command to use that value.
- Passing a nullptr local work-group will now always keep the current command behaviour (either generated by the implementation or user-defined).
- Passing zero to newWorkDim is now an error.
fabiomestre
force-pushed
the
fabio/cmd_buffer_kernel_update
branch
from
52f534d to
d944ff3
Compare
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 1, 2024
…15287) Updates the call to urCommandBufferAppendKernelLaunchExp to use the new UR parameters. Corresponding UR PR: oneapi-src/unified-runtime#1924 --------- Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXPenum to a newUR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXPwhich uses a bitfield instead of a boolean.urCommandBufferUpdateKernelLaunchExpandur_exp_command_buffer_update_kernel_launch_desc_tto make it more intuitive with less complicated errors codes:intel/llvm PR: intel/llvm#15287