[common] fixed some compilation warnings #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
lslusarczyk
force-pushed
the
compilation_fixes_for_sles
branch
from
fcaa71c to
3115127
Compare
Contributor
|
You need to format your code changes. |
lslusarczyk
force-pushed
the
compilation_fixes_for_sles
branch
from
3115127 to
b82b241
Compare
lslusarczyk
force-pushed
the
compilation_fixes_for_sles
branch
2 times, most recently
from
e88e2b4 to
947951c
Compare
lslusarczyk
force-pushed
the
compilation_fixes_for_sles
branch
from
947951c to
fcdcc75
Compare
Contributor
|
👍 |
Contributor
Author
|
@pbalcer , can you take a look again and if all is OK, then merge this? |
pbalcer
reviewed
Oct 3, 2024
| } | ||
|
|
||
| ur_result_t MemBuffer::free() { | ||
| for (const auto &[_, Ptr] : Allocations) { |
Contributor
Author
There was a problem hiding this comment.
AFAIR compiling on jf cluster with g++7 being newest compiler avail there reports warning about "_" as unused variable. These were the only fixes needed to make UR compilable there.
Contributor
There was a problem hiding this comment.
We should not worry about warnings in an old compiler. Just don't set -Werror.
| } | ||
|
|
||
| void context_t::initLayers() { | ||
| for (auto &[layer, _] : layers) { |
Remove excessive semicolons. Use python3.6 friendly alias instead of text param.
lslusarczyk
force-pushed
the
compilation_fixes_for_sles
branch
from
fcdcc75 to
97a22aa
Compare
pbalcer
approved these changes
Oct 3, 2024
Contributor
Author
|
@pbalcer , if all is OK please merge |
RossBrunton
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.