[NATIVECPU] Initial implementation of events on Native CPU #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
force-pushed
the
pietro/events_initial
branch
3 times, most recently
from
454b455 to
53e2bc8
Compare
PietroGhg
force-pushed
the
pietro/events_initial
branch
from
53e2bc8 to
ec5e8ea
Compare
uwedolinsky
approved these changes
Oct 2, 2024
| using args_index_t = std::vector<void *>; | ||
| args_index_t Indices; | ||
| std::vector<size_t> ParamSizes; | ||
| std::vector<bool> OwnsMem; |
There was a problem hiding this comment.
We could probably put these into one vector for performance
| new ur_event_handle_t_(hQueue, UR_COMMAND_MEM_BUFFER_MAP); | ||
| event->tick_start(); | ||
| *ppRetMap = hBuffer->_mem + offset; | ||
| event->tick_end(); |
There was a problem hiding this comment.
This seems to just time fast pointer arithmetic (because it's just enqueue) which is probably less than the overhead of std::lock_guard in tick_end. Just creating the event like in urEnqueueMemUnmap below is probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ur_event_handle_t_, allowing for recording time stamps for events and asynchronous kernel execution.Fixes bugs in handling kernel arguments that have been exposed by the asynchronous execution.
intel/llvm PR: intel/llvm#15564