Skip to content

Install adapters by cmake #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Install adapters by cmake #2169

merged 1 commit into from
Oct 4, 2024

Conversation

@lslusarczyk
Copy link
Contributor

@lslusarczyk lslusarczyk commented Oct 3, 2024

Add installing adapters. It is needed by #2146 and was already reviewed there and was just extracted to this separate PR (with some kind of test added).

@github-actions github-actions bot added ci/cd Continuous integration/devliery loader Loader related feature/bug level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues labels Oct 3, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Oct 3, 2024

With some additional changes in intel/llvm this could also resolve intel/llvm#14924

This was referenced Oct 3, 2024
Closed
Merged
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pbalcer
pbalcer reviewed Oct 4, 2024
View reviewed changes
@pbalcer
Copy link
Contributor

pbalcer commented Oct 4, 2024

If the changes are ready, please undraft them.

@lslusarczyk lslusarczyk marked this pull request as ready for review October 4, 2024 13:07
@lslusarczyk lslusarczyk requested review from a team as code owners October 4, 2024 13:07
@lslusarczyk
Copy link
Contributor Author

lslusarczyk commented Oct 4, 2024 •
edited
Loading

intel/llvm#15590 passed. Failed checks here in UR are:

  • openCL E2E - not related fail, as usual in this check
  • level0 E2E: one test unexpectedly passed, but all checks works on llvm PR

@pbalcer , if all is OK please merge

@lslusarczyk lslusarczyk requested a review from kbenzie October 4, 2024 14:15
steffenlarsen
steffenlarsen approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable! 🚀

PietroGhg
PietroGhg approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

@kbenzie kbenzie merged commit a1b9fa7 into oneapi-src:main Oct 4, 2024
73 of 75 checks passed
@KornevNikita KornevNikita mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@pbalcer pbalcer pbalcer approved these changes

+3 more reviewers

@kbenzie kbenzie kbenzie approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/cd Continuous integration/devliery cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lslusarczyk @kbenzie @pbalcer @lukaszstolarczuk @PietroGhg @steffenlarsen