[L0] Fix binary sizes and binaries returned by urProgramGetInfo #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
force-pushed
the
fix_ur_program_get_info
branch
from
e089640 to
1d7fd6c
Compare
Currently urProgramGetInfo will return UR_RESULT_ERROR_INVALID_PROGRAM if program is built only for a subset of associated devices, i.e. not all devices have level zero module and binaries. This PR fixes this behaviour. Such urProgramGetInfo will return UR_RESULT_SUCCESS and 0 will be returned as binary size for devices which don't have a binary and binary data will not be copied for them.
againull
force-pushed
the
fix_ur_program_get_info
branch
from
1d7fd6c to
3e1a0ea
Compare
Contributor
Author
|
Failures are unrelated: Failed Tests (2): |
Contributor
|
Hello @againull , Looks good to me, can you post the intel/llvm PR using the commit in this PR? |
nrspruit
approved these changes
Nov 13, 2024
Contributor
Author
Hello @nrspruit , thank you for taking a look! Yes, here is associated intel/llvm PR: intel/llvm#16056 |
Contributor
Author
|
@oneapi-src/unified-runtime-maintain Could you please merge this PR. |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 14, 2024
Includes new low-power events API (oneapi-src/unified-runtime#2253) and fixes to urProgramGetInfo (oneapi-src/unified-runtime#2313).
againull
added a commit
to intel/llvm
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently urProgramGetInfo will return UR_RESULT_ERROR_INVALID_PROGRAM if program is built only for a subset of associated devices, i.e. not all devices have level zero module and binaries.
This PR fixes this behaviour. Such urProgramGetInfo will return UR_RESULT_SUCCESS and 0 will be returned as binary size for devices which don't have a binary and binary data will not be copied for them.