Fix the CL_CORE_FUNCTION macro on windows. #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been using the stringizing operator like the linux path.
callumfare
approved these changes
Nov 18, 2024
kbenzie
approved these changes
Nov 18, 2024
Contributor
Author
|
LLVM PR intel/llvm#16106 |
Contributor
|
Can we get this merged? This is blocking our internal branch promotion. Thanks. |
Contributor
@jsji we've assertained that the failures which paused merging this are unrelated, we'll merge this one next. |
Contributor
Thanks @kbenzie and @callumfare ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have been using the stringizing operator like the linux path.