[HIP] Disable SYCL images by default #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the HIP adapter with the CUDA adapter and report SYCL images disabled by default, they're implemented at about the same level as the ones in CUDA, so there's no reason to treat them differently on HIP. Also any future work to improve the HIP image support should focus on bindless images rather than this SYCL image support, so it makes sense to consider this essentially "deprecated".
github-actions
bot
added
cuda
frasercrmck
reviewed
Nov 20, 2024
frasercrmck
approved these changes
Nov 20, 2024
aarongreig
approved these changes
Nov 20, 2024
Contributor
Author
|
intel/llvm change + testing: intel/llvm#16147 |
Contributor
Author
|
E2E failures also happen on other PRs and don't happen on the intel/llvm PR testing so this should be ready although it does need the matching intel/llvm change |
martygrant
added a commit
to npmiller/llvm
that referenced
this pull request
Dec 12, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 12, 2024
This patch adds a variable to enable image support for HIP, and updates the one for CUDA to use the UR naming. SYCL images support is similar for CUDA and HIP, so it makes sense to treat them the same, and any future work on this will focus on bindless images rather than SYCL images. UR side PR: oneapi-src/unified-runtime#2356 --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the HIP adapter with the CUDA adapter and report SYCL images disabled by default, they're implemented at about the same level as the ones in CUDA, so there's no reason to treat them differently on HIP.
Also any future work to improve the HIP image support should focus on bindless images rather than this SYCL image support, so it makes sense to consider this essentially "deprecated".