Skip to content

Merge the adapter and platform enums into one generic backend enum. #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Merge the adapter and platform enums into one generic backend enum. #2377

wants to merge 1 commit into from

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 25, 2024

No description provided.

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Nov 25, 2024
@aarongreig
Copy link
Contributor Author

aarongreig commented Nov 25, 2024

LLVM PR intel/llvm#16173

@aarongreig aarongreig marked this pull request as ready for review November 25, 2024 16:22
@aarongreig aarongreig requested review from a team as code owners November 25, 2024 16:22
kbenzie
kbenzie reviewed Dec 6, 2024
View reviewed changes
include/ur_api.h

///////////////////////////////////////////////////////////////////////////////
/// @brief Defines known backends.
typedef enum ur_backend_t {
Copy link
Contributor

@kbenzie kbenzie Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might smooth the transition to have aliases to the old names for the two enums?

I assume the numerical values are the same so its just a source change.

Copy link
Contributor Author

@aarongreig aarongreig Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're at the point now where the next release this makes it into is a major one, I think we just rip the bandaid off

Copy link
Contributor

@kbenzie kbenzie Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sure.

nrspruit
nrspruit approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for L0

Bensuo
Bensuo approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command buffer changes LGTM

@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch 4 times, most recently from f9b9aff to 9f11e28 Compare January 21, 2025 16:26
@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch from 9f11e28 to 23f10c1 Compare February 4, 2025 15:40
@aarongreig
Copy link
Contributor Author

aarongreig commented Feb 5, 2025

ping @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write

@aarongreig aarongreig added ready to merge Added to PR's which are ready to merge and removed ready to merge Added to PR's which are ready to merge labels Feb 5, 2025
@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch from 23f10c1 to f698cb6 Compare February 11, 2025 17:42
@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Feb 11, 2025
@martygrant
Copy link
Contributor

martygrant commented Feb 20, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch from f698cb6 to f266919 Compare February 24, 2025 11:42
@aarongreig aarongreig force-pushed the aaron/mergeAdapterPlatformBackend branch from f266919 to 81d6a47 Compare February 24, 2025 11:44
@aarongreig aarongreig closed this Feb 24, 2025
@aarongreig aarongreig mentioned this pull request Feb 24, 2025
Merged
martygrant pushed a commit to intel/llvm that referenced this pull request Mar 24, 2025
@aarongreig
[UR] Consolidate platform and adapter backend enums into one. (#16173)
7515943 
UR changes ported from
oneapi-src/unified-runtime#2377
RossBrunton pushed a commit that referenced this pull request Mar 24, 2025
@aarongreig @RossBrunton
Consolidate platform and adapter backend enums into one. (#16173)
4c042ee 
UR changes ported from
#2377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrspruit nrspruit nrspruit approved these changes

+5 more reviewers

@kbenzie kbenzie kbenzie left review comments

@RossBrunton RossBrunton RossBrunton approved these changes

@frasercrmck frasercrmck frasercrmck approved these changes

@hvdijk hvdijk hvdijk approved these changes

@Bensuo Bensuo Bensuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aarongreig @martygrant @RossBrunton @frasercrmck @hvdijk @kbenzie @nrspruit @Bensuo