[rtt] Fix all warnings

Author: onelife

examples/Blink/Blink.ino

@@ -1,11 +1,15 @@
 #include <rtt.h>
 
+// NOTES: "CONFIG_USING_FINSH" and "CONFIG_USING_SPISD" in "rtt.h" may be turned off to save memory
+
 struct rt_thread blink_thread;
 byte blink_thread_stack[1024];
 bool led_state = false;
 
 // user thread entry function
 void blink_thread_entry(void* parameter) {
+  (void)parameter;
+
   rt_kprintf("Start Blink\n");
 
   // the loop is here

src/components/arduino/drv_spi.cpp

@@ -89,8 +89,9 @@ static rt_err_t bsp_spi_open(rt_device_t dev, rt_uint16_t oflag) {
         spi_debug("SPI%d: open with flag %x\n", ctx->chn, oflag);
     } while (0);
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         spi_debug("SPI%d err: open failed [%08x]\n", ctx->chn, ret);
+    }
     return ret;
 }
 
@@ -105,8 +106,9 @@ static rt_err_t bsp_spi_close(rt_device_t dev) {
         spi_debug("SPI%d: closed\n", ctx->chn);
     } while (0);
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         spi_debug("SPI%d err: close failed [%08x]\n", ctx->chn, ret);
+    }
     return ret;
 }
 

src/components/arduino/drv_spisd.cpp

@@ -250,8 +250,9 @@ static rt_err_t sd_read_block(struct bsp_sd_contex *ctx, void *buf,
         ret = RT_EOK;
     } while(0);
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         sd_debug("SPISD err: read block failed! [%02x]\n", ret);
+    }
     return ret;
 }
 
@@ -429,8 +430,9 @@ static rt_err_t sd_write_block(struct bsp_sd_contex *ctx, void *buf,
         ret = RT_EOK;
     } while (0);
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         sd_debug("SPISD err: write block failed! [%02x]\n", ret);
+    }
     return ret;
 }
 
@@ -521,8 +523,9 @@ static rt_err_t bsp_spiSd_init(rt_device_t dev) {
     SD_CS(0);
     rt_device_close(ctx->ldev);
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         sd_debug("SPISD err: init failed! (%08x)\n", ret);
+    }
     return ret;
 }
 
@@ -537,7 +540,7 @@ static rt_size_t bsp_spiSd_read(rt_device_t dev, rt_off_t sector, void *buf,
     if (RT_EOK != err) {
         rt_set_errno(err);
         return 0;
-    };
+    }
     sd_debug("SPISD: read sect %d [%d]\n", sector, count);
 
     /* convert to byte address if necessary */
@@ -803,9 +806,9 @@ static rt_err_t bsp_spiSd_control(rt_device_t dev, rt_int32_t cmd, void *buf) {
         break;
     }
 
-    if (RT_EOK != ret)
+    if (RT_EOK != ret) {
         sd_debug("SPISD err: control failed! [%08x]\n", ret);
-
+    }
     return ret;
 }
 

src/components/dfs/filesystems/elmfat/dfs_elm.c

@@ -102,6 +102,8 @@ int dfs_elm_mount(struct dfs_filesystem *fs, unsigned long rwflag, const void *d
     int index;
     struct rt_device_blk_geometry geometry;
     char logic_nbr[2] = {'0',':'};
+    (void)rwflag;
+    (void)data;
 
     /* get an empty position */
     index = get_disk(RT_NULL);
@@ -476,6 +478,10 @@ int dfs_elm_close(struct dfs_fd *file)
 
 int dfs_elm_ioctl(struct dfs_fd *file, int cmd, void *args)
 {
+    (void)file;
+    (void)cmd;
+    (void)args;
+
     return -ENOSYS;
 }
 
@@ -653,6 +659,8 @@ int dfs_elm_unlink(struct dfs_filesystem *fs, const char *path)
     rt_snprintf(drivers_fn, 256, "%d:%s", vol, path);
 #else
     const char *drivers_fn;
+    (void)fs;
+
     drivers_fn = path;
 #endif
 
@@ -686,6 +694,7 @@ int dfs_elm_rename(struct dfs_filesystem *fs, const char *oldpath, const char *n
     rt_snprintf(drivers_oldfn, 256, "%d:%s", vol, oldpath);
 #else
     const char *drivers_oldfn, *drivers_newfn;
+    (void)fs;
 
     drivers_oldfn = oldpath;
     drivers_newfn = newpath;
@@ -719,6 +728,8 @@ int dfs_elm_stat(struct dfs_filesystem *fs, const char *path, struct stat *st)
     rt_snprintf(drivers_fn, 256, "%d:%s", vol, path);
 #else
     const char *drivers_fn;
+    (void)fs;
+
     drivers_fn = path;
 #endif
 
@@ -824,12 +835,16 @@ INIT_COMPONENT_EXPORT(elm_init);
 /* Initialize a Drive */
 DSTATUS disk_initialize(BYTE drv)
 {
+    (void)drv;
+
     return 0;
 }
 
 /* Return Disk Status */
 DSTATUS disk_status(BYTE drv)
 {
+    (void)drv;
+
     return 0;
 }
 

src/components/dfs/src/dfs.c

@@ -134,7 +134,7 @@ static int fd_alloc(struct dfs_fdtable *fdt, int startfd)
     }
 
     /* allocate a larger FD container */
-    if (idx == fdt->maxfd && fdt->maxfd < DFS_FD_MAX)
+    if (idx == (int)fdt->maxfd && fdt->maxfd < DFS_FD_MAX)
     {
         int cnt, index;
         struct dfs_fd **fds;
@@ -188,7 +188,7 @@ int fd_new(void)
     idx = fd_alloc(fdt, 0);
 
     /* can't find an empty fd entry */
-    if (idx == fdt->maxfd)
+    if (idx == (int)fdt->maxfd)
     {
         idx = -(1 + DFS_FD_OFFSET);
         LOG_E( "DFS fd new is failed! Could not found an empty fd entry.");

src/components/dfs/src/dfs_posix.c

@@ -510,6 +510,7 @@ int mkdir(const char *path, mode_t mode)
     int fd;
     struct dfs_fd *d;
     int result;
+    (void)mode;
 
     fd = fd_new();
     if (fd == -1)
@@ -872,6 +873,8 @@ FINSH_FUNCTION_EXPORT_ALIAS(chdir, cd, change current working directory);
 int access(const char *path, int amode)
 {
     struct stat sb;
+    (void)amode;
+
     if (stat(path, &sb) < 0)
         return -1; /* already sets errno */
 

src/components/finsh/finsh_init.c

@@ -50,6 +50,8 @@ int finsh_flush(struct finsh_parser* parser)
 
 int finsh_reset(struct finsh_parser* parser)
 {
+    (void)parser;
+
     /* finsh init */
     finsh_node_init();
     finsh_var_init();

src/components/finsh/finsh_token.c

@@ -12,14 +12,14 @@
 
 #if defined(RT_USING_FINSH) && !defined(FINSH_USING_MSH_ONLY)
 
-#include "finsh.h"
 #include <stdlib.h>
+#include "finsh.h"
 #include "finsh_token.h"
 #include "finsh_error.h"
 
-#define is_alpha(ch)    ((ch | 0x20) - 'a') < 26u
+#define is_alpha(ch)    ((ch | 0x20) - 'a') < 26
 #define is_digit(ch)    ((ch) >= '0' && (ch) <= '9')
-#define is_xdigit(ch)   (((ch) >= '0' && (ch) <= '9') || (((ch | 0x20) - 'a') < 6u))
+#define is_xdigit(ch)   (((ch) >= '0' && (ch) <= '9') || (((ch | 0x20) - 'a') < 6))
 #define is_separator(ch) !(((ch) >= 'a' && (ch) <= 'z') \
      || ((ch) >= 'A' && (ch) <= 'Z') || ((ch) >= '0' && (ch) <= '9') || ((ch) == '_'))
 #define is_eof(self) (self)->eof
@@ -298,7 +298,7 @@ static void token_run(struct finsh_token* self)
 
 static int token_match_name(struct finsh_token* self, const char* str)
 {
-    int i;
+    unsigned int i;
 
     for (i = 0; i < sizeof(finsh_name_table)/sizeof(struct name_table); i++)
     {
@@ -439,10 +439,10 @@ static int token_proc_escape(struct finsh_token* self)
         token_prev_char(self);
         break;
     default:
-        if ( (ch - '0') < 8u)
+        if ((ch - '0') < 8)
         {
             result = 0;
-            while ( (ch - '0') < 8u )
+            while ((ch - '0') < 8)
             {
                 result = result*8 + ch - '0';
                 ch = token_next_char(self);

src/components/finsh/shell.c

@@ -152,6 +152,8 @@ static char finsh_getchar(void)
 #ifndef RT_USING_POSIX
 static rt_err_t finsh_rx_ind(rt_device_t dev, rt_size_t size)
 {
+    (void)dev;
+    (void)size;
     RT_ASSERT(shell != RT_NULL);
 
     /* release semaphore to let finsh thread rx data */
@@ -461,6 +463,7 @@ static void shell_push_history(struct finsh_shell *shell)
 void finsh_thread_entry(void *parameter)
 {
     char ch;
+    (void)parameter;
 
     /* normal is echo mode */
 #ifndef FINSH_ECHO_DISABLE_DEFAULT

src/kernel/idle.c

@@ -230,6 +230,8 @@ void rt_thread_idle_excute(void)
 
 static void rt_thread_idle_entry(void *parameter)
 {
+    (void)parameter;
+
 #ifdef RT_USING_SMP
     if (rt_hw_cpu_id() != 0)
     {