Update status_codes.py (#250)

Including goats and updating http.dog which supports more status codes.

PS did not change http.cat, eventhough httpcats.com supports more status
codes.

---------

Signed-off-by: fubar1337 <[email protected]>
Co-authored-by: onerandomusername <[email protected]>

Author: fubar1337

monty/exts/utils/status_codes.py

@@ -1,21 +1,34 @@
 from http import HTTPStatus
 from random import choice
+from typing import Literal
 
 import disnake
 from disnake.ext import commands
 
 from monty.bot import Monty
 
 
-HTTP_DOG_URL = "https://httpstatusdogs.com/img/{code}.jpg"
-HTTP_CAT_URL = "https://http.cat/{code}.jpg"
+# why must every single 304 be a large penis
+HTTP_URLS: dict[str, list[tuple[str, tuple[int, ...]]]] = {
+    "cat": [
+        ("https://http.cat/{code}.jpg", ()),
+        ("https://httpcats.com/{code}.jpg", ()),
+    ],
+    "dog": [
+        ("https://http.dog/{code}.jpg", (304,)),
+        ("https://httpstatusdogs.com/img/{code}.jpg", (304, 308, 422)),
+    ],
+    "goat": [
+        ("https://httpgoats.com/{code}.jpg", (304, 422)),
+    ],
+}
 
 
 class HTTPStatusCodes(commands.Cog, name="HTTP Status Codes"):
     """
-    Fetch an image depicting HTTP status codes as a dog or a cat.
+    Fetch an image depicting HTTP status codes as a dog or a cat or as goat.
 
-    If neither animal is selected a cat or dog is chosen randomly for the given status code.
+    If neither animal is selected a cat or dog or goat is chosen randomly for the given status code.
     """
 
     def __init__(self, bot: Monty) -> None:
@@ -27,60 +40,60 @@ def __init__(self, bot: Monty) -> None:
         invoke_without_command=True,
     )
     async def http_status_group(self, ctx: commands.Context, code: int) -> None:
-        """Choose a cat or dog randomly for the given status code."""
-        subcmd = choice((self.http_cat, self.http_dog))
+        """Choose an animal randomly for the given status code."""
+        subcmd = choice((self.http_cat, self.http_dog, self.http_goat))
         await subcmd(ctx, code)
 
-    @http_status_group.command(name="cat")
-    async def http_cat(self, ctx: commands.Context, code: int) -> None:
-        """Sends an embed with an image of a cat, portraying the status code."""
-        embed = disnake.Embed(title=f"**Status: {code}**")
-        url = HTTP_CAT_URL.format(code=code)
+    async def _fetcher(
+        self,
+        ctx: commands.Context,
+        animal: Literal["cat", "dog", "goat"],
+        code: int,
+    ) -> None:
+        url, ignored_codes = choice(HTTP_URLS[animal])
+        if code in ignored_codes:
+            # check the other urls for the animal
+            for url, ignored_codes in HTTP_URLS[animal]:
+                if code not in ignored_codes:
+                    url = url
+                    break
+            else:
+                await ctx.send(f"The {animal} does not have an image for status code {code}.")
+                return
 
+        embed = disnake.Embed(title=f"**Status: {code}**")
+        url = url.format(code=code)
         try:
             HTTPStatus(code)
             async with self.bot.http_session.get(url, allow_redirects=False) as response:
-                if response.status != 404:
+                if response.status == 200:
                     embed.set_image(url=url)
                 else:
                     raise NotImplementedError
+            embed.set_footer(text=f"Powered by {response.url.host}")
 
         except ValueError:
             embed.set_footer(text="Inputted status code does not exist.")
 
         except NotImplementedError:
-            embed.set_footer(text="Inputted status code is not implemented by http.cat yet.")
+            embed.set_footer(text=f"Inputted status code is not implemented by {response.url.host} yet.")
+
+        await ctx.send(embed=embed)
 
-        finally:
-            await ctx.send(embed=embed)
+    @http_status_group.command(name="cat")
+    async def http_cat(self, ctx: commands.Context, code: int) -> None:
+        """Sends an embed with an image of a cat, portraying the status code."""
+        await self._fetcher(ctx, "cat", code)
 
     @http_status_group.command(name="dog")
     async def http_dog(self, ctx: commands.Context, code: int) -> None:
         """Sends an embed with an image of a dog, portraying the status code."""
-        # These codes aren't server-friendly.
-        if code in (304, 422):
-            await self.http_cat(ctx, code)
-            return
-
-        embed = disnake.Embed(title=f"**Status: {code}**")
-        url = HTTP_DOG_URL.format(code=code)
-
-        try:
-            HTTPStatus(code)
-            async with self.bot.http_session.get(url, allow_redirects=False) as response:
-                if response.status != 302:
-                    embed.set_image(url=url)
-                else:
-                    raise NotImplementedError
-
-        except ValueError:
-            embed.set_footer(text="Inputted status code does not exist.")
-
-        except NotImplementedError:
-            embed.set_footer(text="Inputted status code is not implemented by httpstatusdogs.com yet.")
+        await self._fetcher(ctx, "dog", code)
 
-        finally:
-            await ctx.send(embed=embed)
+    @http_status_group.command(name="goat")
+    async def http_goat(self, ctx: commands.Context, code: int) -> None:
+        """Sends an embed with an image of a goat, portraying the status code."""
+        await self._fetcher(ctx, "goat", code)
 
 
 def setup(bot: Monty) -> None: