Skip to content

Commit 3649005

Browse files
danakjAravind Vasudevan
authored andcommitted
Disable Rust tests that fail for benign reasons with LLVM 17.
tests/ui/abi/stack-protector.rs: rust-lang/rust#109671 the test is being optimized in newer LLVM which breaks its expectations. tests/ui/backtrace.rs: rust-lang/rust#109672 the second panic in a double-panic is being optimized out (reasonably correctly) by newer LLVM. Bug: b/274802621, 1401042 Change-Id: I2be621f38dd1630c13eaf9128c76e0d17d684367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375277 Reviewed-by: Hans Wennborg <[email protected]> Commit-Queue: danakj <[email protected]> Cr-Commit-Position: refs/heads/main@{#1122545} NOKEYCHECK=True GitOrigin-RevId: 44d14dacb50f55acb51940cdb322d4e4ee994030
1 parent 0fb5fe2 commit 3649005

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

build_rust.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,25 @@
6363
VERSION_STAMP_PATH, GetPackageVersionForBuild)
6464

6565
EXCLUDED_TESTS = [
66-
# Temporarily disabled due to https://github.com/rust-lang/rust/issues/94322
67-
os.path.join('tests', 'ui', 'numeric', 'numeric-cast.rs'),
68-
# Temporarily disabled due to https://github.com/rust-lang/rust/issues/96497
66+
# https://github.com/rust-lang/rust/issues/45222 which appears to have
67+
# regressed as of a recent LLVM update. This test is purely performance
68+
# related, not correctness.
69+
os.path.join('tests', 'codegen', 'issue-45222.rs'),
70+
# https://github.com/rust-lang/rust/issues/96497
6971
os.path.join('tests', 'codegen', 'issue-96497-slice-size-nowrap.rs'),
7072
# TODO(crbug.com/1347563): Re-enable when fixed.
7173
os.path.join('tests', 'codegen', 'sanitizer-cfi-emit-type-checks.rs'),
7274
os.path.join('tests', 'codegen',
7375
'sanitizer-cfi-emit-type-metadata-itanium-cxx-abi.rs'),
74-
# Temporarily disabled due to https://github.com/rust-lang/rust/issues/45222
75-
# which appears to have regressed as of a recent LLVM update. This test is
76-
# purely performance related, not correctness.
77-
os.path.join('tests', 'codegen', 'issue-45222.rs')
76+
# https://github.com/rust-lang/rust/issues/109671 the test is being
77+
# optimized in newer LLVM which breaks its expectations.
78+
os.path.join('tests', 'ui', 'abi', 'stack-protector.rs'),
79+
# https://github.com/rust-lang/rust/issues/109672 the second panic in a
80+
# double-panic is being optimized out (reasonably correctly) by newer LLVM.
81+
os.path.join('tests', 'ui', 'backtrace.rs'),
82+
# https://github.com/rust-lang/rust/issues/94322 large output from
83+
# compiletests is breaking json parsing of the results.
84+
os.path.join('tests', 'ui', 'numeric', 'numeric-cast.rs'),
7885
]
7986
EXCLUDED_TESTS_WINDOWS = [
8087
# https://github.com/rust-lang/rust/issues/96464

0 commit comments

Comments
 (0)