Skip to content

Commit 554b1c2

Browse files
danakjcopybara-github
authored andcommitted
Remove OVERRIDE_CLANG_REVISION from update_rust.py
This variable was used during the bring-up of the Rust toolchain. Now when we want to roll Clang without Rust, we just change the clang revision and don't change anything in the Rust variables. This works because the package name now contains both toolchains versions in its name. [email protected] Bug: 40212971 Change-Id: I334091e14531b6c03ae09587be7c9af9e854d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887217 Auto-Submit: danakj <[email protected]> Reviewed-by: Arthur Eubanks <[email protected]> Commit-Queue: danakj <[email protected]> Commit-Queue: Arthur Eubanks <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359625} NOKEYCHECK=True GitOrigin-RevId: ac8ff2294ca7cf4f8396bdb6115e5aafd71241ce
1 parent 713372c commit 554b1c2

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

update_rust.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,9 @@
3131

3232
# These fields are written by //tools/clang/scripts/upload_revision.py, and
3333
# should not be changed manually.
34-
#
35-
# In the case that a Rust roll fails and you want to roll Clang alone, reset
36-
# this back to its previous value _AND_ set `OVERRIDE_CLANG_REVISION` below
37-
# to the `CLANG_REVISION` that was in place before the roll.
3834
RUST_REVISION = '009e73825af0e59ad4fc603562e038b3dbd6593a'
3935
RUST_SUB_REVISION = 2
4036

41-
# If not None, this overrides the `CLANG_REVISION` in
42-
# //tools/clang/scripts/update.py in order to download a Rust toolchain that
43-
# was built against a different LLVM than the latest Clang package.
44-
OVERRIDE_CLANG_REVISION = None
45-
4637
# Trunk on 2022-10-15.
4738
#
4839
# The revision specified below should typically be the same as the
@@ -69,8 +60,7 @@
6960

7061
def GetRustClangRevision():
7162
from update import CLANG_REVISION
72-
c = OVERRIDE_CLANG_REVISION if OVERRIDE_CLANG_REVISION else CLANG_REVISION
73-
return (f'{RUST_REVISION}-{RUST_SUB_REVISION}' f'-{c}')
63+
return f'{RUST_REVISION}-{RUST_SUB_REVISION}-{CLANG_REVISION}'
7464

7565

7666
# Get the version of the toolchain package we already have.

0 commit comments

Comments
 (0)