Skip to content

Commit 8ec7744

Browse files
danakjAravind Vasudevan
authored andcommitted
Pass the -isysroot parameter to the linker too.
Bug: 1386212 Change-Id: I66c4314c2deea3799e92741475e9f7fc4129428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200986 Reviewed-by: Collin Baker <[email protected]> Commit-Queue: danakj <[email protected]> Cr-Commit-Position: refs/heads/main@{#1098061} NOKEYCHECK=True GitOrigin-RevId: 1d6394b5d5463cc7351ee6c1e612507395db38e2
1 parent 96986d3 commit 8ec7744

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

build_rust.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -265,33 +265,32 @@ def RunXPy(sub, args, llvm_bins_path, zlib_path, libxml2_dirs, build_mac_arm,
265265
RUSTENV['CFLAGS'] += f' -isysroot {sdk_path}'
266266
RUSTENV['CXXFLAGS'] += f' -isysroot {sdk_path}'
267267
RUSTENV['LDFLAGS'] += f' -isysroot {sdk_path}'
268-
RUSTENV['RUSTFLAGS_BOOTSTRAP'] += (f' -Clink-arg=-isysroot {sdk_path}')
268+
RUSTENV['RUSTFLAGS_BOOTSTRAP'] += (
269+
f' -Clink-arg=-isysroot -Clink-arg={sdk_path}')
269270
RUSTENV['RUSTFLAGS_NOT_BOOTSTRAP'] += (
270-
f' -Clink-arg=-isysroot {sdk_path}')
271+
f' -Clink-arg=-isysroot -Clink-arg={sdk_path}')
271272

272273
if zlib_path:
273274
RUSTENV['CFLAGS'] += f' -I{zlib_path}'
274275
RUSTENV['CXXFLAGS'] += f' -I{zlib_path}'
275276
RUSTENV['LDFLAGS'] += f' {LD_PATH_FLAG}{zlib_path}'
276-
RUSTENV['RUSTFLAGS_BOOTSTRAP'] += (f' -Clink-arg='
277-
f'{LD_PATH_FLAG}{zlib_path}')
278-
RUSTENV['RUSTFLAGS_NOT_BOOTSTRAP'] += (f' -Clink-arg='
279-
f'{LD_PATH_FLAG}{zlib_path}')
277+
RUSTENV['RUSTFLAGS_BOOTSTRAP'] += (
278+
f' -Clink-arg={LD_PATH_FLAG}{zlib_path}')
279+
RUSTENV['RUSTFLAGS_NOT_BOOTSTRAP'] += (
280+
f' -Clink-arg={LD_PATH_FLAG}{zlib_path}')
280281

281282
if libxml2_dirs:
282283
RUSTENV['CFLAGS'] += f' -I{libxml2_dirs.include_dir}'
283284
RUSTENV['CXXFLAGS'] += f' -I{libxml2_dirs.include_dir}'
284285
RUSTENV['LDFLAGS'] += f' {LD_PATH_FLAG}{libxml2_dirs.lib_dir}'
285286
RUSTENV['RUSTFLAGS_BOOTSTRAP'] += (
286-
f' -Clink-arg='
287-
f'{LD_PATH_FLAG}{libxml2_dirs.lib_dir}')
287+
f' -Clink-arg={LD_PATH_FLAG}{libxml2_dirs.lib_dir}')
288288
RUSTENV['RUSTFLAGS_NOT_BOOTSTRAP'] += (
289-
f' -Clink-arg='
290-
f'{LD_PATH_FLAG}{libxml2_dirs.lib_dir}')
289+
f' -Clink-arg={LD_PATH_FLAG}{libxml2_dirs.lib_dir}')
291290

292291
if gcc_toolchain_path:
293292
# We use these flags to avoid linking with the system libstdc++.
294-
gcc_toolchain_flag = (f'--gcc-toolchain={gcc_toolchain_path}')
293+
gcc_toolchain_flag = f'--gcc-toolchain={gcc_toolchain_path}'
295294
RUSTENV['CFLAGS'] += f' {gcc_toolchain_flag}'
296295
RUSTENV['CXXFLAGS'] += f' {gcc_toolchain_flag}'
297296
RUSTENV['LDFLAGS'] += f' {gcc_toolchain_flag}'

0 commit comments

Comments
 (0)