Skip to content

Commit 0a5b8ff

Browse files
vbnogueiradavem330
authored andcommitted
selftests: net: Adapt ethtool mq tests to fix in qdisc graft
Because of patch[1] the graft behaviour changed So the command: tcq replace parent 100:1 handle 204: Is no longer valid and will not delete 100:4 added by command: tcq replace parent 100:4 handle 204: pfifo_fast So to maintain the original behaviour, this patch manually deletes 100:4 and grafts 100:1 Note: This change will also work fine without [1] [1] https://lore.kernel.org/netdev/[email protected]/T/#u Signed-off-by: Victor Nogueira <[email protected]> Reviewed-by: Jamal Hadi Salim <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 001ba09 commit 0a5b8ff

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tools/testing/selftests/drivers/net/netdevsim/tc-mq-visibility.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,12 @@ for root in mq mqprio; do
5858
ethtool -L $NDEV combined 4
5959
n_child_assert 4 "One real queue, rest default"
6060

61-
# Graft some
62-
tcq replace parent 100:1 handle 204:
63-
n_child_assert 3 "Grafted"
61+
# Remove real one
62+
tcq del parent 100:4 handle 204:
63+
64+
# Replace default with pfifo
65+
tcq replace parent 100:1 handle 205: pfifo limit 1000
66+
n_child_assert 3 "Deleting real one, replacing default one with pfifo"
6467

6568
ethtool -L $NDEV combined 1
6669
n_child_assert 1 "Grafted, one"

0 commit comments

Comments
 (0)