Skip to content

Commit df8017e

Browse files
Russell King (Oracle)kuba-moo
authored andcommitted
net: bcm: asp2: remove tx_lpi_enabled
Phylib maintains a copy of tx_lpi_enabled, which will be used to populate the member when phy_ethtool_get_eee(). Therefore, writing to this member before phy_ethtool_get_eee() will have no effect. Remove it. Also remove setting our copy of info->eee.tx_lpi_enabled which becomes write-only. Signed-off-by: Russell King (Oracle) <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Tested-by: Florian Fainelli <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 54033f5 commit df8017e

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -364,14 +364,9 @@ void bcmasp_eee_enable_set(struct bcmasp_intf *intf, bool enable)
364364

365365
static int bcmasp_get_eee(struct net_device *dev, struct ethtool_keee *e)
366366
{
367-
struct bcmasp_intf *intf = netdev_priv(dev);
368-
struct ethtool_keee *p = &intf->eee;
369-
370367
if (!dev->phydev)
371368
return -ENODEV;
372369

373-
e->tx_lpi_enabled = p->tx_lpi_enabled;
374-
375370
return phy_ethtool_get_eee(dev->phydev, e);
376371
}
377372

@@ -394,7 +389,6 @@ static int bcmasp_set_eee(struct net_device *dev, struct ethtool_keee *e)
394389
return ret;
395390
}
396391

397-
intf->eee.tx_lpi_enabled = e->tx_lpi_enabled;
398392
bcmasp_eee_enable_set(intf, true);
399393
}
400394

0 commit comments

Comments
 (0)