Skip to content

Commit 37ac882

Browse files
authored
Merge pull request #2404 from alobaili/master
Introduce the `onFailureView` modifier
2 parents a6ccd8f + 8e41dd9 commit 37ac882

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Sources/SwiftUI/ImageBinder.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ extension KFImage {
7575
} else if let image = context.options.onFailureImage {
7676
self.loadedImage = image
7777
}
78-
7978
self.loading = false
8079
self.markLoaded(sendChangeEvent: false)
8180
}
@@ -135,6 +134,9 @@ extension KFImage {
135134
} else if let image = context.options.onFailureImage {
136135
self.loadedImage = image
137136
}
137+
if let view = context.failureView {
138+
self.failureView = view
139+
}
138140
self.markLoaded(sendChangeEvent: false)
139141
}
140142

Sources/SwiftUI/KFImageRenderer.swift

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,11 @@ struct KFImageRenderer<HoldingView> : View where HoldingView: KFImageHoldingView
5353
} else if let placeholder = context.placeholder {
5454
placeholder(binder.progress)
5555
} else {
56-
Color.clear
56+
if let placeholder = context.placeholder {
57+
placeholder(binder.progress)
58+
} else {
59+
Color.clear
60+
}
5761
}
5862
}
5963
.onAppear { [weak binder = self.binder] in

0 commit comments

Comments
 (0)