Merge pull request #81 from onfido/release-upgrade

Refresh onfido-ruby after onfido-openapi-spec update (5b1da4d)

Author: dvacca-onfido

.release.json

@@ -1,9 +1,9 @@
 {
   "source": {
     "repo_url": "https://github.com/onfido/onfido-openapi-spec",
-    "short_sha": "4b15a26",
-    "long_sha": "4b15a26d432dcb9c3788cece0a46b5157b2e8b99",
-    "version": "v5.1.0"
+    "short_sha": "5b1da4d",
+    "long_sha": "5b1da4d39d507af15a2f1fdb322df60e0726c23c",
+    "version": "v5.1.1"
   },
-  "release": "v5.1.0"
+  "release": "v5.1.1"
 }

README.md

@@ -14,7 +14,7 @@ This version uses Onfido API v3.6. Refer to our [API versioning guide](https://d
 ### Installation
 
 ```ruby
-gem 'onfido', '~> 5.1.0'
+gem 'onfido', '~> 5.1.1'
 ```
 
 Configure with your API token, region and optional timeout (default value is 30):

lib/onfido/api_client.rb

@@ -35,7 +35,7 @@ class ApiClient
     # @option config [Configuration] Configuration for initializing the object, default to Configuration.default
     def initialize(config = Configuration.default)
       @config = config
-      @user_agent = "onfido-ruby/5.1.0"
+      @user_agent = "onfido-ruby/5.1.1"
       @default_headers = {
         'Content-Type' => 'application/json',
         'User-Agent' => @user_agent
@@ -175,7 +175,7 @@ def deserialize_file(response, stream)
 
       # reconstruct content
       content = stream.join
-      content = content.unpack('m').join if response.headers['Content-Transfer-Encoding'] == 'binary'
+      content = content.unpack('m').join if response.headers['Content-Transfer-Encoding'] == 'base64'  
       content = content.force_encoding(encoding)
 
       # return byte stream

lib/onfido/version.rb

@@ -11,5 +11,5 @@
 =end
 
 module Onfido
-  VERSION = '5.1.0'
+  VERSION = '5.1.1'
 end

spec/integrations/check_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_check'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::Check do
   describe 'Checks' do
@@ -74,10 +75,10 @@
       onfido_api.resume_check(check_id)
     end
 
-    it 'downloads a check' do
-      file = onfido_api.download_check(check_id)
+    describe 'downloading a check' do
+      let(:file) { onfido_api.download_check(check_id) }
 
-      expect(file.size).to be > 0
+      it_behaves_like "a valid PDF file"
     end
   end
 end

spec/integrations/document_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_document'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::Document do
   describe 'Documents' do
@@ -27,10 +28,10 @@
       expect(get_document.id).to eq document_id
     end
 
-    it 'downloads a document' do
-      file = onfido_api.download_document(document_id)
+    describe 'downloading a document' do
+      let(:file) { onfido_api.download_document(document_id) }
 
-      expect(file.size).to be > 0
+      it_behaves_like "a valid PNG file", 361771
     end
 
     it 'cannot download an inexistent document' do
@@ -41,10 +42,10 @@
       }
     end
 
-    it 'downloads an NFC face' do
-      file = onfido_api.download_nfc_face(nfc_face_id)
+    describe 'downloading an NFC face' do
+      let(:file) { onfido_api.download_nfc_face(nfc_face_id) }
 
-      expect(file.size).to be > 0
+      it_behaves_like "a valid PNG file", 471345
     end
 
     it 'cannot download an inexistent NFC face' do

spec/integrations/id_photo_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_applicant'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::IdPhoto do
   describe 'Id Photo' do
@@ -35,10 +36,10 @@
       expect(get_id_photo.id).to eq id_photo_id
     end
 
-    it 'downloads id photo' do
-      file = onfido_api.download_id_photo(id_photo_id)
+    describe 'downloading id photo' do
+      let(:file) { onfido_api.download_id_photo(id_photo_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid PNG file", 395856
     end
 
     it 'raises an error with the correct status code when trying to download an inexistent id photo' do

spec/integrations/live_photo_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_live_photo'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::LivePhoto do
   describe 'Live Photo' do
@@ -27,10 +28,10 @@
       expect(live_photo).to be_an_instance_of Onfido::LivePhoto
     end
 
-    it 'downloads live photo' do
-      file = onfido_api.download_live_photo(live_photo_id)
+    describe 'downloading live photo' do
+      let(:file) { onfido_api.download_live_photo(live_photo_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid PNG file", 395856
     end
 
     it 'raises an error with the correct status code when trying to download an inexistent live photo' do

spec/integrations/live_video_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_onfido'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::LiveVideo do
   describe 'Live Video' do
@@ -24,16 +25,16 @@
       expect(get_live_video).to be_an_instance_of Onfido::LiveVideo
     end
 
-    it 'downloads live video' do
-      file = onfido_api.download_live_video(live_video_id)
+    describe 'downloading live video' do
+      let(:file) { onfido_api.download_live_video(live_video_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid MP4 file", 165093
     end
 
-    it 'downloads live video frame' do
-      file = onfido_api.download_live_video_frame(live_video_id)
+    describe 'downloading live video frame' do
+      let(:file) { onfido_api.download_live_video_frame(live_video_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid JPEG file", 1692
     end
 
     it 'raises an error with the correct status code when trying to download an inexistent live video' do

spec/integrations/motion_capture_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative '../shared_contexts/with_onfido'
+require_relative '../shared_examples/file_examples'
 
 describe Onfido::MotionCapture do
   describe 'Motion Capture' do
@@ -24,16 +25,16 @@
       expect(get_motion_capture).to be_an_instance_of Onfido::MotionCapture
     end
 
-    it 'downloads motion capture' do
-      file = onfido_api.download_motion_capture(motion_id)
+    describe 'downloading live video' do
+      let(:file) { onfido_api.download_motion_capture(motion_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid MP4 file", 2720276
     end
 
-    it 'downloads motion capture frame' do
-      file = onfido_api.download_motion_capture_frame(motion_id)
+    describe 'downloading live video frame' do
+      let(:file) { onfido_api.download_motion_capture_frame(motion_id) }
 
-      expect(file.length).to be > 0
+      it_behaves_like "a valid JPEG file", 75627
     end
 
     it 'raises an error with the correct status code when trying to download an inexistent motion capture' do