Skip to content

Commit 64ff062

Browse files
authored
Merge pull request #915 from bjartek/main
send in own logger and expose function
2 parents fc26d2f + dfeb4d6 commit 64ff062

File tree

8 files changed

+24
-19
lines changed

8 files changed

+24
-19
lines changed

bootstrap/bootstrap.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,15 @@ type Bootstrap struct {
8181
}
8282

8383
func New(config config.Config) (*Bootstrap, error) {
84-
logger := zerolog.New(config.LogWriter).
85-
With().Timestamp().Str("version", api.Version).
86-
Logger().Level(config.LogLevel)
84+
var logger zerolog.Logger
85+
86+
if config.Logger != nil {
87+
logger = *config.Logger
88+
} else {
89+
logger = zerolog.New(config.LogWriter).
90+
With().Timestamp().Str("version", api.Version).
91+
Logger().Level(config.LogLevel)
92+
}
8793

8894
client, err := setupCrossSporkClient(config, logger)
8995
if err != nil {

config/config.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ type Config struct {
8080
LogLevel zerolog.Level
8181
// LogWriter defines the writer used for logging
8282
LogWriter io.Writer
83+
// Logger if you bring your own
84+
Logger *zerolog.Logger
8385
// RateLimit requests made by the client identified by IP over any protocol (ws/http).
8486
RateLimit uint64
8587
// Address header used to identified clients, usually set by the proxy

models/block.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ func (b *Block) Hash() (gethCommon.Hash, error) {
6565
return b.Block.Hash()
6666
}
6767

68-
// decodeBlockEvent takes a cadence event that contains executed block payload and
68+
// DecodeBlockEvent takes a cadence event that contains executed block payload and
6969
// decodes it into the Block type.
70-
func decodeBlockEvent(event cadence.Event) (*Block, *events.BlockEventPayload, error) {
70+
func DecodeBlockEvent(event cadence.Event) (*Block, *events.BlockEventPayload, error) {
7171
payload, err := events.DecodeBlockEventPayload(event)
7272
if err != nil {
7373
return nil, nil, fmt.Errorf(

models/block_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func Test_DecodeBlockExecutedEvent(t *testing.T) {
120120
encEv, err := ev.Payload.ToCadence(flowGo.Previewnet)
121121
require.NoError(t, err)
122122

123-
decBlock, _, err := decodeBlockEvent(encEv)
123+
decBlock, _, err := DecodeBlockEvent(encEv)
124124
require.NoError(t, err)
125125

126126
assert.Equal(t, decBlock, block)
@@ -158,7 +158,7 @@ func Test_DecodingLegacyBlockExecutedEvent(t *testing.T) {
158158
hashToCadenceArrayValue(block.TransactionHashRoot),
159159
}).WithType(eventType)
160160

161-
b, _, err := decodeBlockEvent(legacyEvent)
161+
b, _, err := DecodeBlockEvent(legacyEvent)
162162
require.NoError(t, err)
163163

164164
require.Equal(t, block.ParentBlockHash, b.ParentBlockHash)

models/events.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func decodeCadenceEvents(events flow.BlockEvents) (*CadenceEvents, error) {
104104
return nil, fmt.Errorf("EVM block was already set for Flow block: %d", events.Height)
105105
}
106106

107-
block, blockEventPayload, err := decodeBlockEvent(val)
107+
block, blockEventPayload, err := DecodeBlockEvent(val)
108108
if err != nil {
109109
return nil, err
110110
}
@@ -115,7 +115,7 @@ func decodeCadenceEvents(events flow.BlockEvents) (*CadenceEvents, error) {
115115
}
116116

117117
if isTransactionExecutedEvent(val) {
118-
tx, receipt, txEventPayload, err := decodeTransactionEvent(val)
118+
tx, receipt, txEventPayload, err := DecodeTransactionEvent(val)
119119
if err != nil {
120120
return nil, err
121121
}

models/receipt_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
func Test_DecodeReceipts(t *testing.T) {
1111
cdcEv, rec := createTestEvent(t, evmTxBinary)
1212

13-
_, receipt, _, err := decodeTransactionEvent(cdcEv)
13+
_, receipt, _, err := DecodeTransactionEvent(cdcEv)
1414
require.NoError(t, err)
1515

1616
assert.Equal(t, BaseFeePerGas, receipt.EffectiveGasPrice)

models/transaction.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,10 @@ func (tc TransactionCall) MarshalBinary() ([]byte, error) {
225225
return append([]byte{tc.Type()}, encoded...), err
226226
}
227227

228-
// decodeTransactionEvent takes a cadence event for transaction executed
228+
// DecodeTransactionEvent takes a cadence event for transaction executed
229229
// and decodes its payload into a Transaction interface and a Receipt.
230230
// The concrete type will be either a TransactionCall or a DirectCall.
231-
func decodeTransactionEvent(event cadence.Event) (
231+
func DecodeTransactionEvent(event cadence.Event) (
232232
Transaction,
233233
*Receipt,
234234
*events.TransactionEventPayload,

models/transaction_test.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ func createTestEvent(t *testing.T, txBinary string) (cadence.Event, *types.Resul
8585
func Test_DecodeEVMTransaction(t *testing.T) {
8686
cdcEv, _ := createTestEvent(t, evmTxBinary)
8787

88-
decTx, _, _, err := decodeTransactionEvent(cdcEv)
88+
decTx, _, _, err := DecodeTransactionEvent(cdcEv)
8989
require.NoError(t, err)
9090
require.IsType(t, TransactionCall{}, decTx)
9191

@@ -131,7 +131,7 @@ func Test_DecodeEVMTransaction(t *testing.T) {
131131
func Test_DecodeDirectCall(t *testing.T) {
132132
cdcEv, _ := createTestEvent(t, directCallBinary)
133133

134-
decTx, _, _, err := decodeTransactionEvent(cdcEv)
134+
decTx, _, _, err := DecodeTransactionEvent(cdcEv)
135135
require.NoError(t, err)
136136
require.IsType(t, DirectCall{}, decTx)
137137

@@ -179,7 +179,7 @@ func Test_UnmarshalTransaction(t *testing.T) {
179179

180180
cdcEv, _ := createTestEvent(t, evmTxBinary)
181181

182-
tx, _, _, err := decodeTransactionEvent(cdcEv)
182+
tx, _, _, err := DecodeTransactionEvent(cdcEv)
183183
require.NoError(t, err)
184184

185185
encodedTx, err := tx.MarshalBinary()
@@ -233,7 +233,7 @@ func Test_UnmarshalTransaction(t *testing.T) {
233233

234234
cdcEv, _ := createTestEvent(t, directCallBinary)
235235

236-
tx, _, _, err := decodeTransactionEvent(cdcEv)
236+
tx, _, _, err := DecodeTransactionEvent(cdcEv)
237237
require.NoError(t, err)
238238

239239
encodedTx, err := tx.MarshalBinary()
@@ -277,7 +277,6 @@ func Test_UnmarshalTransaction(t *testing.T) {
277277
assert.Equal(t, uint64(0), decTx.BlobGas())
278278
assert.Equal(t, uint64(61), decTx.Size())
279279
})
280-
281280
}
282281

283282
func TestValidateTransaction(t *testing.T) {
@@ -406,11 +405,9 @@ func TestValidateTransaction(t *testing.T) {
406405
}
407406
})
408407
}
409-
410408
}
411409

412410
func TestValidateConsensusRules(t *testing.T) {
413-
414411
head := &gethTypes.Header{
415412
Number: big.NewInt(20_182_324),
416413
Time: uint64(time.Now().Unix()),

0 commit comments

Comments
 (0)