apply review comments

Author: janezpodhostnik

api/debug.go

@@ -361,7 +361,8 @@ func (d *DebugAPI) TraceCall(
 	return tracer.GetResult()
 }
 
-// FlowHeight returns the Flow height for the given EVM block.
+// FlowHeight returns the Flow height for the given EVM block specified either by EVM
+// block height or EVM block hash.
 func (d *DebugAPI) FlowHeight(
 	_ context.Context,
 	blockNrOrHash rpc.BlockNumberOrHash,

tests/e2e_web3js_test.go

@@ -36,7 +36,7 @@ func TestWeb3_E2E(t *testing.T) {
 		runWeb3Test(t, "debug_traces_test")
 	})
 
-	t.Run("test transaction traces", func(t *testing.T) {
+	t.Run("test debug utils", func(t *testing.T) {
 		runWeb3Test(t, "debug_util_test")
 	})
 

tests/web3js/debug_util_test.js

@@ -1,14 +1,15 @@
 const { assert } = require('chai')
 const helpers = require('./helpers')
+const conf = require('./config')
 
 it('should retrieve flow height', async () => {
-    response = await helpers.callRPCMethod(
+    let response = await helpers.callRPCMethod(
         'debug_flowHeight',
         ['latest']
     )
     assert.equal(response.status, 200)
     assert.isDefined(response.body)
 
     let height = response.body.result
-    assert.isTrue(height > 0)
+    assert.equal(height, conf.startBlockHeight)
 })