Merge pull request #679 from onflow/mpeter/fix-eth-syncing-starting-height

Fix race for `startingBlock` field of `eth_syncing` endpoint

Author: m-Peter

api/api.go

@@ -170,13 +170,8 @@ func NewBlockChainAPI(
 	receipts storage.ReceiptIndexer,
 	ratelimiter limiter.Store,
 	collector metrics.Collector,
-) (*BlockChainAPI, error) {
-	// get the height from which the indexing resumed since the last restart, this is needed for syncing status.
-	indexingResumedHeight, err := blocks.LatestEVMHeight()
-	if err != nil {
-		return nil, fmt.Errorf("failed to retrieve the indexing resumed height: %w", err)
-	}
-
+	indexingResumedHeight uint64,
+) *BlockChainAPI {
 	return &BlockChainAPI{
 		logger:                logger,
 		config:                config,
@@ -187,7 +182,7 @@ func NewBlockChainAPI(
 		indexingResumedHeight: indexingResumedHeight,
 		limiter:               ratelimiter,
 		collector:             collector,
-	}, nil
+	}
 }
 
 // BlockNumber returns the block number of the chain head.

bootstrap/bootstrap.go

@@ -246,7 +246,14 @@ func (b *Bootstrap) StartAPIServer(ctx context.Context) error {
 		return fmt.Errorf("failed to create rate limiter: %w", err)
 	}
 
-	blockchainAPI, err := api.NewBlockChainAPI(
+	// get the height from which the indexing resumed since the last restart,
+	// this is needed for the `eth_syncing` endpoint.
+	indexingResumedHeight, err := b.storages.Blocks.LatestEVMHeight()
+	if err != nil {
+		return fmt.Errorf("failed to retrieve the indexing resumed height: %w", err)
+	}
+
+	blockchainAPI := api.NewBlockChainAPI(
 		b.logger,
 		b.config,
 		evm,
@@ -255,10 +262,8 @@ func (b *Bootstrap) StartAPIServer(ctx context.Context) error {
 		b.storages.Receipts,
 		ratelimiter,
 		b.collector,
+		indexingResumedHeight,
 	)
-	if err != nil {
-		return err
-	}
 
 	streamAPI := api.NewStreamAPI(
 		b.logger,
@@ -577,14 +582,16 @@ func Run(ctx context.Context, cfg *config.Config, ready component.ReadyFunc) err
 		return err
 	}
 
-	if err := boot.StartEventIngestion(ctx); err != nil {
-		return fmt.Errorf("failed to start event ingestion engine: %w", err)
-	}
-
+	// Start the API Server first, to avoid any races with incoming
+	// EVM events, that might affect the starting state.
 	if err := boot.StartAPIServer(ctx); err != nil {
 		return fmt.Errorf("failed to start API server: %w", err)
 	}
 
+	if err := boot.StartEventIngestion(ctx); err != nil {
+		return fmt.Errorf("failed to start event ingestion engine: %w", err)
+	}
+
 	if err := boot.StartMetricsServer(ctx); err != nil {
 		return fmt.Errorf("failed to start metrics server: %w", err)
 	}