Skip to content

Commit 2203da7

Browse files
committed
collection guarantees only published after collection is being successfully persisted as finalized
1 parent b5c6094 commit 2203da7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

module/finalizer/collection/finalizer.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,10 @@ func (f *Finalizer) MakeFinal(blockID flow.Identifier) error {
190190
return fmt.Errorf("could not construct guarantee: %w", err)
191191
}
192192

193-
// TODO: collections should only be pushed to consensus nodes, once they are successfully persisted as finalized:
194-
//storage.OnCommitSucceed(rw, func() {
195-
f.pusher.SubmitCollectionGuarantee(guarantee)
196-
//})
193+
// collections should only be pushed to consensus nodes, once they are successfully persisted as finalized:
194+
storage.OnCommitSucceed(rw, func() {
195+
f.pusher.SubmitCollectionGuarantee(guarantee)
196+
})
197197

198198
return nil
199199
})

0 commit comments

Comments
 (0)