Skip to content

Commit 39b4531

Browse files
committed
use assert.Error
1 parent f285e90 commit 39b4531

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

utils/merr/closer_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,29 +36,29 @@ func TestCloseAndMergeError(t *testing.T) {
3636
// Test case 3: only close error
3737
closer.closeError = errors.New("close error")
3838
err = CloseAndMergeError(closer, nil)
39-
require.NotNil(t, err)
39+
require.Error(t, err)
4040
require.Contains(t, err.Error(), "close error")
4141

4242
// Test case 4: both original error and close error
4343
err = CloseAndMergeError(closer, errors.New("original error"))
44-
require.NotNil(t, err)
44+
require.Error(t, err)
4545
require.Contains(t, err.Error(), "original error")
4646
require.Contains(t, err.Error(), "close error")
4747

4848
// Test case 5: original error is storage.ErrNotFound
4949
err = CloseAndMergeError(closer, fmt.Errorf("not found error: %w", storage.ErrNotFound))
50-
require.NotNil(t, err)
50+
require.Error(t, err)
5151
require.ErrorIs(t, err, storage.ErrNotFound)
5252

5353
// Test case 6: close error is storage.ErrNotFound
5454
closer.closeError = fmt.Errorf("not found error: %w", storage.ErrNotFound)
5555
err = CloseAndMergeError(closer, nil)
56-
require.NotNil(t, err)
56+
require.Error(t, err)
5757
require.True(t, errors.Is(err, storage.ErrNotFound))
5858

5959
// Test case 7: error check works with multierror
6060
closer.closeError = fmt.Errorf("exception")
6161
err = CloseAndMergeError(closer, fmt.Errorf("not found error: %w", storage.ErrNotFound))
62-
require.NotNil(t, err)
62+
require.Error(t, err)
6363
require.True(t, errors.Is(err, storage.ErrNotFound))
6464
}

0 commit comments

Comments
 (0)