Skip to content

Commit 42cb96b

Browse files
committed
Updating Makefile to push flow version as tags
Signed-off-by: haroldsphinx <[email protected]>
1 parent 241ab9d commit 42cb96b

File tree

2 files changed

+42
-12
lines changed

2 files changed

+42
-12
lines changed

Makefile

Lines changed: 37 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# The short Git commit hash
22
SHORT_COMMIT := $(shell git rev-parse --short HEAD)
3+
BRANCH_NAME:=$(shell git rev-parse --abbrev-ref HEAD | tr '/' '-')
34
# The Git commit hash
45
COMMIT := $(shell git rev-parse HEAD)
56
# The tag of the current commit, otherwise empty
@@ -9,6 +10,9 @@ VERSION := $(shell git describe --tags --abbrev=2 --match "v*" --match "secure-c
910
# dynamically split up CI jobs into smaller jobs that can be run in parallel
1011
GO_TEST_PACKAGES := ./...
1112

13+
FLOW_GO_TAG := v0.28.15
14+
15+
1216
# Image tag: if image tag is not set, set it with version (or short commit if empty)
1317
ifeq (${IMAGE_TAG},)
1418
IMAGE_TAG := ${VERSION}
@@ -33,6 +37,7 @@ GOARCH := $(shell go env GOARCH)
3337
# The location of the k8s YAML files
3438
K8S_YAMLS_LOCATION_STAGING=./k8s/staging
3539

40+
3641
# docker container registry
3742
export CONTAINER_REGISTRY := gcr.io/flow-container-registry
3843
export DOCKER_BUILDKIT := 1
@@ -248,12 +253,12 @@ docker-ci-integration:
248253
docker-build-collection:
249254
docker build -f cmd/Dockerfile --build-arg TARGET=./cmd/collection --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG) --build-arg GOARCH=$(GOARCH) --target production \
250255
--label "git_commit=${COMMIT}" --label "git_tag=${IMAGE_TAG}" \
251-
-t "$(CONTAINER_REGISTRY)/collection:latest" -t "$(CONTAINER_REGISTRY)/collection:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/collection:$(IMAGE_TAG)" .
256+
-t "$(CONTAINER_REGISTRY)/collection:latest" -t "$(CONTAINER_REGISTRY)/collection:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/collection:$(IMAGE_TAG)" -t "$(CONTAINER_REGISTRY)/collection:$(FLOW_GO_TAG)" .
252257

253258
.PHONY: docker-build-collection-without-netgo
254259
docker-build-collection-without-netgo:
255260
docker build -f cmd/Dockerfile --build-arg TAGS=relic --build-arg TARGET=./cmd/collection --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG_NO_NETGO) --build-arg GOARCH=$(GOARCH) --target production \
256-
--label "git_commit=${COMMIT}" --label "git_tag=$(IMAGE_TAG_NO_NETGO)" -t "$(CONTAINER_REGISTRY)/collection:$(IMAGE_TAG_NO_NETGO)" .
261+
--label "git_commit=${COMMIT}" --label "git_tag=$(IMAGE_TAG_NO_NETGO)" -t "$(CONTAINER_REGISTRY)/collection:$(IMAGE_TAG_NO_NETGO)" .
257262

258263
.PHONY: docker-build-collection-debug
259264
docker-build-collection-debug:
@@ -264,7 +269,7 @@ docker-build-collection-debug:
264269
docker-build-consensus:
265270
docker build -f cmd/Dockerfile --build-arg TARGET=./cmd/consensus --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG) --build-arg GOARCH=$(GOARCH) --target production \
266271
--label "git_commit=${COMMIT}" --label "git_tag=${IMAGE_TAG}" \
267-
-t "$(CONTAINER_REGISTRY)/consensus:latest" -t "$(CONTAINER_REGISTRY)/consensus:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/consensus:$(IMAGE_TAG)" .
272+
-t "$(CONTAINER_REGISTRY)/consensus:latest" -t "$(CONTAINER_REGISTRY)/consensus:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/consensus:$(IMAGE_TAG)" -t "$(CONTAINER_REGISTRY)/consensus:$(FLOW_GO_TAG)" .
268273

269274
.PHONY: docker-build-consensus-without-netgo
270275
docker-build-consensus-without-netgo:
@@ -280,7 +285,7 @@ docker-build-consensus-debug:
280285
docker-build-execution:
281286
docker build -f cmd/Dockerfile --build-arg TARGET=./cmd/execution --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG) --build-arg GOARCH=$(GOARCH) --target production \
282287
--label "git_commit=${COMMIT}" --label "git_tag=${IMAGE_TAG}" \
283-
-t "$(CONTAINER_REGISTRY)/execution:latest" -t "$(CONTAINER_REGISTRY)/execution:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/execution:$(IMAGE_TAG)" .
288+
-t "$(CONTAINER_REGISTRY)/execution:latest" -t "$(CONTAINER_REGISTRY)/execution:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/execution:$(IMAGE_TAG)" -t "$(CONTAINER_REGISTRY)/execution:$(FLOW_GO_TAG)" .
284289

285290
.PHONY: docker-build-execution-without-netgo
286291
docker-build-execution-without-netgo:
@@ -306,7 +311,7 @@ docker-build-execution-corrupt:
306311
docker-build-verification:
307312
docker build -f cmd/Dockerfile --build-arg TARGET=./cmd/verification --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG) --build-arg GOARCH=$(GOARCH) --target production \
308313
--label "git_commit=${COMMIT}" --label "git_tag=${IMAGE_TAG}" \
309-
-t "$(CONTAINER_REGISTRY)/verification:latest" -t "$(CONTAINER_REGISTRY)/verification:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/verification:$(IMAGE_TAG)" .
314+
-t "$(CONTAINER_REGISTRY)/verification:latest" -t "$(CONTAINER_REGISTRY)/verification:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/verification:$(IMAGE_TAG)" -t "$(CONTAINER_REGISTRY)/verification:$(FLOW_GO_TAG)" .
310315

311316
.PHONY: docker-build-verification-without-netgo
312317
docker-build-verification-without-netgo:
@@ -332,7 +337,7 @@ docker-build-verification-corrupt:
332337
docker-build-access:
333338
docker build -f cmd/Dockerfile --build-arg TARGET=./cmd/access --build-arg COMMIT=$(COMMIT) --build-arg VERSION=$(IMAGE_TAG) --build-arg GOARCH=$(GOARCH) --target production \
334339
--label "git_commit=${COMMIT}" --label "git_tag=${IMAGE_TAG}" \
335-
-t "$(CONTAINER_REGISTRY)/access:latest" -t "$(CONTAINER_REGISTRY)/access:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/access:$(IMAGE_TAG)" .
340+
-t "$(CONTAINER_REGISTRY)/access:latest" -t "$(CONTAINER_REGISTRY)/access:$(SHORT_COMMIT)" -t "$(CONTAINER_REGISTRY)/access:$(IMAGE_TAG)" -t "$(CONTAINER_REGISTRY)/access:$(FLOW_GO_TAG)" .
336341

337342
.PHONY: docker-build-access-without-netgo
338343
docker-build-access-without-netgo:
@@ -419,6 +424,7 @@ docker-build-benchnet: docker-build-flow docker-build-loader
419424
docker-push-collection:
420425
docker push "$(CONTAINER_REGISTRY)/collection:$(SHORT_COMMIT)"
421426
docker push "$(CONTAINER_REGISTRY)/collection:$(IMAGE_TAG)"
427+
docker push "$(CONTAINER_REGISTRY)/collection:$(FLOW_GO_TAG)"
422428

423429
.PHONY: docker-push-collection-without-netgo
424430
docker-push-collection-without-netgo:
@@ -432,6 +438,7 @@ docker-push-collection-latest: docker-push-collection
432438
docker-push-consensus:
433439
docker push "$(CONTAINER_REGISTRY)/consensus:$(SHORT_COMMIT)"
434440
docker push "$(CONTAINER_REGISTRY)/consensus:$(IMAGE_TAG)"
441+
docker push "$(CONTAINER_REGISTRY)/consensus:$(FLOW_GO_TAG)"
435442

436443
.PHONY: docker-push-consensus-without-netgo
437444
docker-push-consensus-without-netgo:
@@ -445,6 +452,13 @@ docker-push-consensus-latest: docker-push-consensus
445452
docker-push-execution:
446453
docker push "$(CONTAINER_REGISTRY)/execution:$(SHORT_COMMIT)"
447454
docker push "$(CONTAINER_REGISTRY)/execution:$(IMAGE_TAG)"
455+
docker push "$(CONTAINER_REGISTRY)/execution:$(FLOW_GO_TAG)"
456+
457+
.PHONY: docker-push-execution-corrupt
458+
docker-push-execution-corrupt:
459+
docker push "$(CONTAINER_REGISTRY)/execution-corrupted:$(SHORT_COMMIT)"
460+
docker push "$(CONTAINER_REGISTRY)/execution-corrupted:$(IMAGE_TAG)"
461+
448462

449463
.PHONY: docker-push-execution-without-netgo
450464
docker-push-execution-without-netgo:
@@ -458,6 +472,12 @@ docker-push-execution-latest: docker-push-execution
458472
docker-push-verification:
459473
docker push "$(CONTAINER_REGISTRY)/verification:$(SHORT_COMMIT)"
460474
docker push "$(CONTAINER_REGISTRY)/verification:$(IMAGE_TAG)"
475+
docker push "$(CONTAINER_REGISTRY)/verification:$(FLOW_GO_TAG)"
476+
477+
.PHONY: docker-push-verification-corrupt
478+
docker-push-verification-corrupt:
479+
docker push "$(CONTAINER_REGISTRY)/verification-corrupted:$(SHORT_COMMIT)"
480+
docker push "$(CONTAINER_REGISTRY)/verification-corrupted:$(IMAGE_TAG)"
461481

462482
.PHONY: docker-push-verification-without-netgo
463483
docker-push-verification-without-netgo:
@@ -471,6 +491,12 @@ docker-push-verification-latest: docker-push-verification
471491
docker-push-access:
472492
docker push "$(CONTAINER_REGISTRY)/access:$(SHORT_COMMIT)"
473493
docker push "$(CONTAINER_REGISTRY)/access:$(IMAGE_TAG)"
494+
docker push "$(CONTAINER_REGISTRY)/access:$(FLOW_GO_TAG)"
495+
496+
.PHONY: docker-push-access-corrupt
497+
docker-push-access-corrupt:
498+
docker push "$(CONTAINER_REGISTRY)/access-corrupted:$(SHORT_COMMIT)"
499+
docker push "$(CONTAINER_REGISTRY)/access-corrupted:$(IMAGE_TAG)"
474500

475501
.PHONY: docker-push-access-without-netgo
476502
docker-push-access-without-netgo:
@@ -479,6 +505,7 @@ docker-push-access-without-netgo:
479505
.PHONY: docker-push-access-latest
480506
docker-push-access-latest: docker-push-access
481507
docker push "$(CONTAINER_REGISTRY)/access:latest"
508+
482509

483510
.PHONY: docker-push-observer
484511
docker-push-observer:
@@ -520,6 +547,9 @@ docker-push-flow-without-netgo: docker-push-collection-without-netgo docker-push
520547
.PHONY: docker-push-flow-latest
521548
docker-push-flow-latest: docker-push-collection-latest docker-push-consensus-latest docker-push-execution-latest docker-push-verification-latest docker-push-access-latest docker-push-observer-latest
522549

550+
.PHONY: docker-push-flow-corrupt
551+
docker-push-flow-corrupt: docker-push-access-corrupt docker-push-execution-corrupt docker-push-verification-corrupt
552+
523553
.PHONY: docker-push-benchnet
524554
docker-push-benchnet: docker-push-flow docker-push-loader
525555

@@ -621,4 +651,4 @@ monitor-rollout:
621651
kubectl --kubeconfig=$$kconfig rollout status statefulsets.apps flow-collection-node-v1; \
622652
kubectl --kubeconfig=$$kconfig rollout status statefulsets.apps flow-consensus-node-v1; \
623653
kubectl --kubeconfig=$$kconfig rollout status statefulsets.apps flow-execution-node-v1; \
624-
kubectl --kubeconfig=$$kconfig rollout status statefulsets.apps flow-verification-node-v1
654+
kubectl --kubeconfig=$$kconfig rollout status statefulsets.apps flow-verification-node-v1

integration/benchnet2/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# eventually, DOCKER_TAG will use the git commit hash
22
# this isn't working fully yet so fow now we will specify the explicit Git tag to use as the Docker tag
33
#DOCKER_TAG := $(shell git rev-parse --short HEAD)
4-
COMMIT_SHA:=$(shell git rev-parse --short=9 HEAD)
4+
FLOW_GO_TAG := v0.28.15
55
BRANCH_NAME:=$(shell git rev-parse --abbrev-ref HEAD | tr '/' '-')
6+
DOCKER_TAG := $(FLOW_GO_TAG)
7+
COMMIT_SHA:=$(shell git rev-parse --short=9 HEAD)
68

7-
8-
ifeq (${FLOW_GO_TAG},)
9-
FLOW_GO_TAG := ${COMMIT_SHA}
9+
ifeq ($(strip $(FLOW_GO_TAG)),)
10+
$(eval FLOW_GO_TAG=$(BRANCH_NAME))
1011
endif
1112

12-
DOCKER_TAG := $(FLOW_GO_TAG)
1313

1414

1515
# default value of the Docker base registry URL which can be overriden when invoking the Makefile

0 commit comments

Comments
 (0)