Skip to content

Commit 522e0f3

Browse files
Apply suggestions from code review
Co-authored-by: Jordan Schalm <[email protected]>
1 parent a0068e1 commit 522e0f3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

utils/merr/closer_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func TestCloseAndMergeError(t *testing.T) {
3030

3131
// Test case 2: only original error
3232
err = CloseAndMergeError(closer, errors.New("original error"))
33-
require.NotNil(t, err)
33+
require.Error(t, err)
3434
require.Contains(t, err.Error(), "original error")
3535

3636
// Test case 3: only close error
@@ -48,7 +48,7 @@ func TestCloseAndMergeError(t *testing.T) {
4848
// Test case 5: original error is storage.ErrNotFound
4949
err = CloseAndMergeError(closer, fmt.Errorf("not found error: %w", storage.ErrNotFound))
5050
require.NotNil(t, err)
51-
require.True(t, errors.Is(err, storage.ErrNotFound))
51+
require.ErrorIs(t, err, storage.ErrNotFound)
5252

5353
// Test case 6: close error is storage.ErrNotFound
5454
closer.closeError = fmt.Errorf("not found error: %w", storage.ErrNotFound)

0 commit comments

Comments
 (0)