Skip to content

Commit 6932613

Browse files
Apply suggestions from code review
Co-authored-by: Yurii Oleksyshyn <[email protected]>
1 parent b81799f commit 6932613

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

consensus/hotstuff/signature/block_signer_decoder_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func (s *blockSignerDecoderSuite) Test_CommitteeException() {
7878
require.Empty(s.T(), ids)
7979
require.NotErrorIs(s.T(), err, model.ErrViewForUnknownEpoch)
8080
require.False(s.T(), signature.IsInvalidSignerIndicesError(err))
81-
require.True(s.T(), errors.Is(err, exception))
81+
require.ErrorIs(s.T(), err, exception)
8282
})
8383
s.Run("ByBlock exception", func() {
8484
exception := errors.New("unexpected exception")
@@ -90,7 +90,7 @@ func (s *blockSignerDecoderSuite) Test_CommitteeException() {
9090
require.Empty(s.T(), ids)
9191
require.NotErrorIs(s.T(), err, model.ErrViewForUnknownEpoch)
9292
require.False(s.T(), signature.IsInvalidSignerIndicesError(err))
93-
require.True(s.T(), errors.Is(err, exception))
93+
require.ErrorIs(s.T(), err, exception)
9494
})
9595
}
9696

storage/badger/operation/common_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ func TestRetrieveUnencodeable(t *testing.T) {
276276
})
277277
}
278278

279+
// TestExists verifies that `exists` returns correct results in different scenarios.
279280
func TestExists(t *testing.T) {
280281
unittest.RunWithBadgerDB(t, func(db *badger.DB) {
281282
t.Run("non-existent key", func(t *testing.T) {

0 commit comments

Comments
 (0)