Merge pull request #7906 from onflow/webauthn-updates

remove URL base 64 padding from webauthn challenge encoding

Author: Kay-Zee

integration/testnet/client.go

@@ -197,7 +197,7 @@ func (c *Client) validWebAuthnExtensionData(transactionMessage []byte) ([]byte,
 		return nil, nil, err
 	}
 	authNChallenge := hasher.ComputeHash(transactionMessage)
-	authNChallengeBase64Url := base64.URLEncoding.EncodeToString(authNChallenge)
+	authNChallengeBase64Url := base64.RawURLEncoding.EncodeToString(authNChallenge)
 	validUserFlag := byte(0x01)
 	validClientDataOrigin := "https://testing.com"
 	rpIDHash := unittest.RandomBytes(32)

model/flow/transaction_test.go

@@ -437,7 +437,7 @@ func TestTransactionAuthenticationSchemes(t *testing.T) {
 
 		transactionMessage := transactionBody.EnvelopeMessage()
 		authNChallenge := hasher.ComputeHash(transactionMessage)
-		authNChallengeBase64Url := base64.URLEncoding.EncodeToString(authNChallenge)
+		authNChallengeBase64Url := base64.RawURLEncoding.EncodeToString(authNChallenge)
 		validUserFlag := byte(0x01)
 		validClientDataOrigin := "https://testing.com"
 		rpIDHash := unittest.RandomBytes(32)

model/flow/webauthn.go

@@ -88,7 +88,7 @@ func validateWebAuthNExtensionData(extensionData []byte, payload []byte) (bool,
 	}
 
 	// base64url decode the challenge, as that's the encoding used client side according to https://www.w3.org/TR/webauthn-3/#dictionary-client-data
-	clientDataChallenge, err := base64.URLEncoding.DecodeString(clientData.Challenge)
+	clientDataChallenge, err := base64.RawURLEncoding.DecodeString(clientData.Challenge)
 	if err != nil {
 		return false, nil
 	}