update tests

Author: zhangchiqing

storage/store/protocol_kv_store_test.go

@@ -74,13 +74,13 @@ func TestProtocolKVStore_StoreTx(t *testing.T) {
 		})
 		require.NoError(t, err)
 
-		// Store same data again - should not error
+		// Store same data again - should error
 		err = unittest.WithLock(t, lockManager, storage.LockInsertBlock, func(lctx lockctx.Context) error {
 			return db.WithReaderBatchWriter(func(rw storage.ReaderBatchWriter) error {
 				return store.BatchStore(lctx, rw, stateID, expected)
 			})
 		})
-		require.NoError(t, err)
+		require.ErrorIs(t, err, storage.ErrAlreadyExists)
 
 		// Attempt to store different data with the same stateID
 		dataDifferent := &flow.PSKeyValueStoreData{
@@ -93,7 +93,7 @@ func TestProtocolKVStore_StoreTx(t *testing.T) {
 				return store.BatchStore(lctx, rw, stateID, dataDifferent)
 			})
 		})
-		require.ErrorIs(t, err, storage.ErrDataMismatch)
+		require.ErrorIs(t, err, storage.ErrAlreadyExists)
 
 		// Attempt to store different version with the same stateID
 		versionDifferent := &flow.PSKeyValueStoreData{
@@ -106,7 +106,7 @@ func TestProtocolKVStore_StoreTx(t *testing.T) {
 				return store.BatchStore(lctx, rw, stateID, versionDifferent)
 			})
 		})
-		require.ErrorIs(t, err, storage.ErrDataMismatch)
+		require.ErrorIs(t, err, storage.ErrAlreadyExists)
 	})
 }
 
@@ -131,13 +131,13 @@ func TestProtocolKVStore_IndexTx(t *testing.T) {
 		})
 		require.NoError(t, err)
 
-		// Index same data again - should not error
+		// Index same data again - should error with storage.ErrAlreadyExists
 		err = unittest.WithLock(t, lockManager, storage.LockInsertBlock, func(lctx lockctx.Context) error {
 			return db.WithReaderBatchWriter(func(rw storage.ReaderBatchWriter) error {
 				return store.BatchIndex(lctx, rw, blockID, stateID)
 			})
 		})
-		require.NoError(t, err)
+		require.ErrorIs(t, err, storage.ErrAlreadyExists)
 
 		// Attempt to index different stateID with same blockID
 		differentStateID := unittest.IdentifierFixture()
@@ -146,7 +146,7 @@ func TestProtocolKVStore_IndexTx(t *testing.T) {
 				return store.BatchIndex(lctx, rw, blockID, differentStateID)
 			})
 		})
-		require.ErrorIs(t, err, storage.ErrDataMismatch)
+		require.ErrorIs(t, err, storage.ErrAlreadyExists)
 	})
 }