Skip to content

Commit 9b7db83

Browse files
Apply suggestions from code review
Co-authored-by: Jordan Schalm <[email protected]>
1 parent 7ad5f51 commit 9b7db83

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

module/metrics/collection.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ func NewCollectionCollector(tracer module.Tracer) *CollectionCollector {
6060
Subsystem: subsystemProposal,
6161
Buckets: []float64{1, 2, 5, 10, 20},
6262
Name: "collection_size",
63-
Help: "number of transactions included in the block",
63+
Help: "number of transactions included ONLY in the cluster blocks proposed by this node",
6464
}, []string{LabelChain}),
6565

6666
priorityTxns: promauto.NewHistogramVec(prometheus.HistogramOpts{
6767
Namespace: namespaceCollection,
6868
Subsystem: subsystemProposal,
6969
Buckets: []float64{1, 2, 5, 10, 20},
70-
Name: "priority_transactions_count",
71-
Help: "number of priority transactions included in the block",
70+
Name: "priority_transactions",
71+
Help: "number of priority transactions included ONLY in cluster blocks proposed by this node",
7272
}, []string{LabelChain}),
7373
}
7474

@@ -101,7 +101,9 @@ func (cc *CollectionCollector) CollectionMaxSize(size uint) {
101101
cc.maxCollectionSize.Set(float64(size))
102102
}
103103

104-
// ClusterBlockCreated informs about cluster block being created.
104+
// ClusterBlockCreated informs about cluster block being proposed by this node.
105+
// CAUTION: These metrics will represent a partial picture of cluster block creation across the network,
106+
// as each node will only report on cluster blocks where they are the proposer.
105107
// It reports several metrics, specifically how many transactions have been included and how many of them are priority txns.
106108
func (cc *CollectionCollector) ClusterBlockCreated(block *cluster.Block, priorityTxnsCount uint) {
107109
chainID := block.ChainID

0 commit comments

Comments
 (0)