Skip to content

Commit 9e37f14

Browse files
committed
Apply suggestions from code review
1 parent 1fc3a19 commit 9e37f14

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

engine/collection/pusher/engine.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ func (e *Engine) processOutboundMessages(ctx context.Context) error {
146146
// Because the pusher engine does not accept inputs from the network,
147147
// always drop any messages and return an error.
148148
func (e *Engine) Process(channel channels.Channel, originID flow.Identifier, message any) error {
149-
return fmt.Errorf("pusher engine should only receive local messages on the same node")
149+
return fmt.Errorf("pusher engine should only receive local messages on the same node: got message %T on channel %v from origin %v", message, channel, originID)
150150
}
151151

152152
// SubmitCollectionGuarantee adds a collection guarantee to the engine's queue

engine/collection/pusher/engine_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ func (suite *Suite) TestSubmitCollectionGuarantee() {
9797
Run(func(_ mock.Arguments) { close(done) }).Return(nil).Once()
9898

9999
suite.engine.SubmitCollectionGuarantee(guarantee)
100-
// TODO signature?
101-
//suite.Require().Nil(err)
102100

103101
unittest.RequireCloseBefore(suite.T(), done, time.Second, "message not sent")
104102

0 commit comments

Comments
 (0)