Clean up emulator dead code

Author: pattyshack

fvm/context.go

@@ -226,31 +226,6 @@ func WithExtensiveTracing() Option {
 	}
 }
 
-// TODO(patrick): rm after https://github.com/onflow/flow-emulator/pull/306
-// is merged and integrated.
-//
-// WithTransactionProcessors sets the transaction processors for a
-// virtual machine context.
-func WithTransactionProcessors(processors ...interface{}) Option {
-	return func(ctx Context) Context {
-		executeBody := false
-		for _, p := range processors {
-			switch p.(type) {
-			case *TransactionInvoker:
-				executeBody = true
-			default:
-				panic("Unexpected transaction processor")
-			}
-		}
-
-		ctx.AuthorizationChecksEnabled = false
-		ctx.SequenceNumberCheckAndIncrementEnabled = false
-		ctx.AccountKeyWeightThreshold = 0
-		ctx.TransactionBodyExecutionEnabled = executeBody
-		return ctx
-	}
-}
-
 // WithServiceAccount enables or disables calls to the Flow service account.
 func WithServiceAccount(enabled bool) Option {
 	return func(ctx Context) Context {
@@ -269,13 +244,6 @@ func WithContractRemovalRestricted(enabled bool) Option {
 	}
 }
 
-// @Depricated please use WithContractDeploymentRestricted instead of this
-// this has been kept to reduce breaking change on the emulator, but would be
-// removed at some point.
-func WithRestrictedDeployment(restricted bool) Option {
-	return WithContractDeploymentRestricted(restricted)
-}
-
 // WithRestrictedContractDeployment enables or disables restricted contract deployment for a
 // virtual machine context. Warning! this would be overridden with the flag stored on chain.
 // this is just a fallback value

fvm/derived/table.go

@@ -10,9 +10,6 @@ import (
 	"github.com/onflow/flow-go/fvm/storage/logical"
 )
 
-// TODO(patrick): rm once emulator is updated
-const EndOfBlockExecutionTime = logical.EndOfBlockExecutionTime
-
 // ValueComputer is used by DerivedDataTable's GetOrCompute to compute the
 // derived value when the value is not in DerivedDataTable (i.e., "cache miss").
 type ValueComputer[TKey any, TVal any] interface {

fvm/environment/facade_env.go

@@ -141,24 +141,6 @@ func newFacadeEnvironment(
 	return env
 }
 
-// TODO(patrick): remove once emulator is updated.
-func NewScriptEnvironment(
-	ctx context.Context,
-	tracer tracing.TracerSpan,
-	params EnvironmentParams,
-	nestedTxn state.NestedTransaction,
-	derivedTxn derived.DerivedTransactionCommitter,
-) *facadeEnvironment {
-	return NewScriptEnv(
-		ctx,
-		tracer,
-		params,
-		storage.SerialTransaction{
-			NestedTransaction:           nestedTxn,
-			DerivedTransactionCommitter: derivedTxn,
-		})
-}
-
 // This is mainly used by command line tools, the emulator, and cadence tools
 // testing.
 func NewScriptEnvironmentFromStorageSnapshot(

fvm/fvm.go

@@ -38,9 +38,6 @@ type ProcedureOutput struct {
 
 	// Output only by script.
 	Value cadence.Value
-
-	// TODO(patrick): rm after updating emulator to use ComputationUsed
-	GasUsed uint64
 }
 
 func (output *ProcedureOutput) PopulateEnvironmentValues(
@@ -53,8 +50,6 @@ func (output *ProcedureOutput) PopulateEnvironmentValues(
 		return fmt.Errorf("error getting computation used: %w", err)
 	}
 	output.ComputationUsed = computationUsed
-	// TODO(patrick): rm after updating emulator to use ComputationUsed
-	output.GasUsed = computationUsed
 
 	memoryUsed, err := env.MemoryUsed()
 	if err != nil {

fvm/transactionInvoker.go

@@ -19,14 +19,6 @@ import (
 	"github.com/onflow/flow-go/module/trace"
 )
 
-// TODO(patrick): rm once emulator is updated.
-type TransactionInvoker struct {
-}
-
-func NewTransactionInvoker() *TransactionInvoker {
-	return &TransactionInvoker{}
-}
-
 type TransactionExecutorParams struct {
 	AuthorizationChecksEnabled bool