Merge #4055

4055: optimize CI tests r=tarakby a=tarakby

When retrying tests, the setup phases are also retried which slows downs the overall jobs. Setup includes installing tools and building relic lib. This PR separates the setup phase from running the actual tests. The setup steps won't be retried if the tests fail. 

Test jobs updated:

- `unit-test`
- `unit-test-modules`

Co-authored-by: Tarak Ben Youssef <[email protected]>
Co-authored-by: Tarak Ben Youssef <[email protected]>

Author: 3 people

.github/workflows/ci.yml

@@ -115,12 +115,14 @@ jobs:
       with:
         go-version: ${{ env.GO_VERSION }}
         cache: true
+    - name: Setup tests (${{ matrix.targets.name }}
+      run: VERBOSE=1 make -e GO_TEST_PACKAGES="${{ matrix.targets.packages }}" install-tools
     - name: Run tests (${{ matrix.targets.name }})
       uses: nick-fields/retry@v2
       with:
         timeout_minutes: 25
         max_attempts: 3
-        command: VERBOSE=1 make -e GO_TEST_PACKAGES="${{ matrix.targets.packages }}" ci
+        command: VERBOSE=1 make -e GO_TEST_PACKAGES="${{ matrix.targets.packages }}" test
 
       # TODO(rbtz): re-enable when we fix exisiting races.
       #env:
@@ -162,17 +164,17 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
           cache: true
+      - name: Setup tests (${{ matrix.name }})
+        run: make ${{ matrix.make1 }}
       - name: Run tests (${{ matrix.name }})
         env:
           RACE_DETECTOR: ${{ matrix.race }}
         uses: nick-fields/retry@v2
         with:
           timeout_minutes: 25
           max_attempts: ${{ matrix.retries }}
-          # run `make1` target before running `make2` target inside each module's root
-          command: |
-            make ${{ matrix.make1 }}
-            VERBOSE=1 make -C ${{ matrix.name }} ${{ matrix.make2 }}
+          # run `make2` target inside each module's root
+          command: VERBOSE=1 make -C ${{ matrix.name }} ${{ matrix.make2 }}
       - name: Upload coverage report
         uses: codecov/codecov-action@v3
         with: