Skip to content

Commit bd80179

Browse files
author
Misha
committed
Update Makefile
moved PROJECT_NAME to init target, added validate pre-requisite for k8s-pod-health target
1 parent 1877ff6 commit bd80179

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

integration/benchnet2/Makefile

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,17 @@ validate:
2727
ifeq ($(strip $(VALID_EXECUTION)), 1)
2828
# multiple execution nodes are required to prevent seals being generated in case of execution forking.
2929
$(error Number of Execution nodes should be no less than 2)
30-
else ifeq ($(strip $(PROJECT_NAME)),)
31-
$(eval PROJECT_NAME=$(COMMIT_SHA))
3230
else ifeq ($(strip $(VALID_CONSENSUS)), 1)
3331
$(error Number of Consensus nodes should be no less than 2)
3432
else ifeq ($(strip $(VALID_COLLECTION)), 1)
3533
$(error Number of Collection nodes should be no less than 6)
3634
else ifeq ($(strip $(NAMESPACE)),)
37-
$(error Namespace cannot be empty)
35+
$(error NAMESPACE cannot be empty)
36+
endif
37+
38+
init:
39+
ifeq ($(strip $(PROJECT_NAME)),)
40+
$(eval PROJECT_NAME=$(COMMIT_SHA))
3841
endif
3942

4043
# assumes there is a checked out version of flow-go in a "flow-go" sub-folder at this level so that the bootstrap executable
@@ -57,13 +60,13 @@ gen-helm-l2:
5760
# runs bootstrap to generate all node info
5861
# runs level 1 automation to read bootstrap data and generate data input for level 2
5962
# runs level 2 automation to generate values.yml based on template and data values from previous step
60-
gen-helm-values: validate gen-bootstrap gen-helm-l1 gen-helm-l2
63+
gen-helm-values: validate init gen-bootstrap gen-helm-l1 gen-helm-l2
6164

6265
# main target for deployment
63-
deploy-all: validate gen-helm-values k8s-secrets-create helm-deploy
66+
deploy-all: validate init gen-helm-values k8s-secrets-create helm-deploy
6467

6568
# main target for cleaning up a deployment
66-
clean-all: validate k8s-delete k8s-delete-secrets clean-bootstrap clean-gen-helm clean-flow
69+
clean-all: validate init k8s-delete k8s-delete-secrets clean-bootstrap clean-gen-helm clean-flow
6770

6871
clean-bootstrap:
6972
rm -rf ./bootstrap
@@ -88,8 +91,8 @@ k8s-delete-secrets:
8891
k8s-expose-locally: validate
8992
kubectl port-forward service/access1-${PROJECT_NAME} 9000:9000 --namespace ${NAMESPACE}
9093

91-
k8s-pod-health:
92-
kubectl get pods
94+
k8s-pod-health: validate
95+
kubectl get pods --namespace ${NAMESPACE}
9396

9497
k8s-test-network-accessibility:
9598
flow blocks get latest --host localhost:9000

0 commit comments

Comments
 (0)