Linted and fixed tests

Author: durkmurder

consensus/integration/nodes_test.go

@@ -427,9 +427,6 @@ func createNode(
 	notifier.AddConsumer(counterConsumer)
 	notifier.AddConsumer(logConsumer)
 
-	cleaner := &storagemock.Cleaner{}
-	cleaner.On("RunGC")
-
 	require.Equal(t, participant.nodeInfo.NodeID, localID)
 	privateKeys, err := participant.nodeInfo.PrivateKeys()
 	require.NoError(t, err)
@@ -589,7 +586,6 @@ func createNode(
 		metricsCollector,
 		metricsCollector,
 		tracer,
-		cleaner,
 		headersDB,
 		payloadsDB,
 		fullState,

engine/consensus/compliance/core_test.go

@@ -61,7 +61,6 @@ type CommonSuite struct {
 	me                *module.Local
 	metrics           *metrics.NoopCollector
 	tracer            realModule.Tracer
-	cleaner           *storage.Cleaner
 	headers           *storage.Headers
 	payloads          *storage.Payloads
 	state             *protocol.ParticipantState
@@ -111,10 +110,6 @@ func (cs *CommonSuite) SetupTest() {
 		},
 	)
 
-	// set up storage cleaner
-	cs.cleaner = &storage.Cleaner{}
-	cs.cleaner.On("RunGC").Return()
-
 	// set up header storage mock
 	cs.headers = &storage.Headers{}
 	cs.headers.On("Store", mock.Anything).Return(
@@ -257,7 +252,6 @@ func (cs *CommonSuite) SetupTest() {
 		cs.metrics,
 		cs.metrics,
 		cs.tracer,
-		cs.cleaner,
 		cs.headers,
 		cs.payloads,
 		cs.state,

storage/badger/cleaner.go

@@ -3,15 +3,15 @@
 package badger
 
 import (
-	"github.com/onflow/flow-go/module/component"
-	"github.com/onflow/flow-go/module/irrecoverable"
 	"math/rand"
 	"time"
 
 	"github.com/dgraph-io/badger/v2"
 	"github.com/rs/zerolog"
 
 	"github.com/onflow/flow-go/module"
+	"github.com/onflow/flow-go/module/component"
+	"github.com/onflow/flow-go/module/irrecoverable"
 )
 
 // Cleaner uses component.ComponentManager to implement module.Startable and module.ReadyDoneAware