Cadence tracing is a build tag now

Author: turbolent

cmd/util/cmd/debug-script/cmd.go

@@ -127,9 +127,7 @@ func run(*cobra.Command, []string) {
 		}
 	}
 
-	// TODO:
-	const traceCadence = false
-	debugger := debug.NewRemoteDebugger(chain, log.Logger, traceCadence)
+	debugger := debug.NewRemoteDebugger(chain, log.Logger)
 
 	// TODO: add support for arguments
 	var arguments [][]byte

cmd/util/cmd/debug-tx/cmd.go

@@ -40,7 +40,6 @@ var (
 	flagUseExecutionDataAPI bool
 	flagDumpRegisters       bool
 	flagTracePath           string
-	flagTraceCadence        bool
 )
 
 var Cmd = &cobra.Command{
@@ -74,8 +73,6 @@ func init() {
 	Cmd.Flags().BoolVar(&flagDumpRegisters, "dump-registers", false, "dump registers")
 
 	Cmd.Flags().StringVar(&flagTracePath, "trace", "", "enable tracing to given path")
-
-	Cmd.Flags().BoolVar(&flagTraceCadence, "trace-cadence", false, "trace Cadence")
 }
 
 func run(_ *cobra.Command, args []string) {
@@ -233,7 +230,6 @@ func runTransactionID(txID flow.Identifier, flowClient *client.Client, chain flo
 	debugger := debug.NewRemoteDebugger(
 		chain,
 		log.Logger,
-		flagTraceCadence,
 		fvmOptions...,
 	)
 

utils/debug/remoteDebugger.go

@@ -2,11 +2,9 @@ package debug
 
 import (
 	"github.com/onflow/cadence"
-	"github.com/onflow/cadence/runtime"
 	"github.com/rs/zerolog"
 
 	"github.com/onflow/flow-go/fvm"
-	reusableRuntime "github.com/onflow/flow-go/fvm/runtime"
 	"github.com/onflow/flow-go/fvm/storage/snapshot"
 	"github.com/onflow/flow-go/model/flow"
 )
@@ -27,7 +25,6 @@ const reusableCadenceRuntimePoolSize = 1000
 func NewRemoteDebugger(
 	chain flow.Chain,
 	logger zerolog.Logger,
-	traceCadence bool,
 	options ...fvm.Option,
 ) *RemoteDebugger {
 	vm := fvm.NewVirtualMachine()
@@ -41,13 +38,6 @@ func NewRemoteDebugger(
 				fvm.WithLogger(logger),
 				fvm.WithChain(chain),
 				fvm.WithAuthorizationChecksEnabled(false),
-				fvm.WithReusableCadenceRuntimePool(
-					reusableRuntime.NewReusableCadenceRuntimePool(
-						reusableCadenceRuntimePoolSize,
-						runtime.Config{
-							TracingEnabled: traceCadence,
-						},
-					)),
 				fvm.WithEVMEnabled(true),
 			},
 			options...,