fix access_test

Author: peterargue

engine/access/access_test.go

@@ -726,6 +726,7 @@ func (suite *Suite) TestGetSealedTransaction() {
 
 		collectionIndexer, err := ingestioncollections.NewIndexer(
 			suite.log,
+			db,
 			collectionExecutedMetric,
 			suite.state,
 			all.Blocks,
@@ -816,8 +817,8 @@ func (suite *Suite) TestGetSealedTransaction() {
 
 		// block until the collection is processed by the indexer
 		require.Eventually(suite.T(), func() bool {
-			isStored, err := collectionIndexer.IsCollectionInStorage(collection.ID())
-			return isStored && err == nil
+			_, err := collections.LightByID(collection.ID())
+			return err == nil
 		}, 1*time.Second, 10*time.Millisecond, "collection not indexed")
 
 		// 5. Client requests a transaction
@@ -984,6 +985,7 @@ func (suite *Suite) TestGetTransactionResult() {
 
 		collectionIndexer, err := ingestioncollections.NewIndexer(
 			suite.log,
+			db,
 			collectionExecutedMetric,
 			suite.state,
 			all.Blocks,
@@ -1259,6 +1261,7 @@ func (suite *Suite) TestExecuteScript() {
 
 		collectionIndexer, err := ingestioncollections.NewIndexer(
 			suite.log,
+			db,
 			collectionExecutedMetric,
 			suite.state,
 			all.Blocks,

engine/access/ingestion/collections/syncer.go

@@ -212,10 +212,14 @@ func (s *Syncer) requestMissingCollections(ctx context.Context, forceSendRequest
 		return fmt.Errorf("failed to get finalized block: %w", err)
 	}
 
+	if lastFullBlockHeight >= lastFinalizedBlock.Height {
+		return nil
+	}
+
 	// only send requests if we are sufficiently behind the latest finalized block to avoid spamming
 	// collection nodes with requests.
 	shouldSendRequestsToNetwork := forceSendRequests
-	if lastFullBlockHeight < lastFinalizedBlock.Height && (lastFinalizedBlock.Height-lastFullBlockHeight >= s.missingCollectionRequestThreshold) {
+	if lastFinalizedBlock.Height-lastFullBlockHeight >= s.missingCollectionRequestThreshold {
 		shouldSendRequestsToNetwork = true
 	}