Skip to content

Commit df8ae97

Browse files
committed
Only log process execution failure
1 parent f58b0a2 commit df8ae97

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

engine/execution/computation/computer/computer.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -647,10 +647,13 @@ func (e *blockComputer) executeProcessCallback(
647647
}
648648

649649
if txn.Output().Err != nil {
650-
return nil, 0, fmt.Errorf(
651-
"process callback transaction %s error: %v",
652-
request.txnIdStr,
653-
txn.Output().Err)
650+
// if the process transaction fails we log the critical error but don't return an error
651+
// so that block execution continues and only the scheduled transactions halt
652+
callbackLogger.Error().
653+
Err(txn.Output().Err).
654+
Bool("critical_error", true).
655+
Uint64("height", request.ctx.BlockHeader.Height).
656+
Msg("system process transaction output error")
654657
}
655658

656659
callbackTxs, err := blueprints.ExecuteCallbacksTransactions(e.vmCtx.Chain, txn.Output().Events)

0 commit comments

Comments
 (0)