Skip to content

Commit f0aeedf

Browse files
Apply suggestions from code review
Co-authored-by: Alexander Hentschel <[email protected]>
1 parent d68c634 commit f0aeedf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

module/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ type CollectionMetrics interface {
621621
// CollectionMaxSize measures the current maximum size of a collection.
622622
CollectionMaxSize(size uint)
623623

624-
// ClusterBlockCreated informs about cluster block being proposed by this node.
624+
// ClusterBlockCreated informs about cluster blocks being PROPOSED by THIS NODE.
625625
// CAUTION: These metrics will represent a partial picture of cluster block creation across the network,
626626
// as each node will only report on cluster blocks where they are the proposer.
627627
ClusterBlockCreated(block *cluster.Block, priorityTxnsCount uint)

module/metrics/collection.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ type CollectionCollector struct {
1616
finalizedHeight *prometheus.GaugeVec // tracks the finalized height
1717
maxCollectionSize prometheus.Gauge // tracks the maximum collection size
1818
guarantees *prometheus.HistogramVec // counts the number/size of FINALIZED collections
19-
collectionSize *prometheus.HistogramVec
20-
priorityTxns *prometheus.HistogramVec
19+
collectionSize *prometheus.HistogramVec // number of transactions included ONLY in the cluster blocks proposed by this node
20+
priorityTxns *prometheus.HistogramVec // number of priority transactions included ONLY in cluster blocks proposed by this node
2121
}
2222

2323
var _ module.CollectionMetrics = (*CollectionCollector)(nil)

0 commit comments

Comments
 (0)