self review

Author: archandatta

cmd/create.go

@@ -49,6 +49,7 @@ func runCreateApp(cmd *cobra.Command, args []string) error {
 		return fmt.Errorf("failed to resolve app path: %w", err)
 	}
 
+	// TODO: handle overwrite gracefully (prompt user)
 	// Check if directory already exists
 	if _, err := os.Stat(appPath); err == nil {
 		return fmt.Errorf("directory %s already exists", appName)
@@ -59,7 +60,7 @@ func runCreateApp(cmd *cobra.Command, args []string) error {
 		return fmt.Errorf("failed to create directory: %w", err)
 	}
 
-	fmt.Printf("\nCreating a new %s %s\n\n", language, template)
+	pterm.Println(fmt.Sprintf("\nCreating a new %s %s\n", language, template))
 
 	spinner, _ := pterm.DefaultSpinner.Start("Copying template files...")
 

pkg/create/prompts.go

@@ -60,15 +60,19 @@ func handleLangugePrompt() (string, error) {
 }
 
 func PromptForLanguage(providedLanguage string) (string, error) {
-	l := NormalizeLanguage(providedLanguage)
-	if l != "" && !slices.Contains(SupportedLanguages, l) {
+	if providedLanguage == "" {
 		return handleLangugePrompt()
-	} else if providedLanguage != "" {
+	}
+
+	l := NormalizeLanguage(providedLanguage)
+	if slices.Contains(SupportedLanguages, l) {
 		return l, nil
 	}
+
 	return handleLangugePrompt()
 }
 
+// TODO: add validation for template
 func PromptForTemplate(providedTemplate string) (string, error) {
 	if providedTemplate != "" {
 		return providedTemplate, nil

pkg/create/types.go

@@ -7,8 +7,6 @@ const (
 	TemplatePrompt = "Select a template:"
 )
 
-type Language string
-
 const (
 	LanguageTypeScript          = "typescript"
 	LanguagePython              = "python"
@@ -19,14 +17,14 @@ const (
 type TemplateInfo struct {
 	Name        string
 	Description string
-	Languages   []Language
+	Languages   []string
 }
 
 var Templates = map[string]TemplateInfo{
 	"sample-app": {
 		Name:        "Sample App",
 		Description: "Implements basic Kernel apps",
-		Languages:   []Language{LanguageTypeScript, LanguagePython},
+		Languages:   []string{LanguageTypeScript, LanguagePython},
 	},
 }
 

pkg/create/types_test.go

@@ -39,6 +39,6 @@ func TestTemplates(t *testing.T) {
 	assert.NotEmpty(t, sampleApp.Languages, "Template should support at least one language")
 
 	// Should support both typescript and python
-	assert.Contains(t, sampleApp.Languages, Language(LanguageTypeScript), "sample-app should support typescript")
-	assert.Contains(t, sampleApp.Languages, Language(LanguagePython), "sample-app should support python")
+	assert.Contains(t, sampleApp.Languages, string(LanguageTypeScript), "sample-app should support typescript")
+	assert.Contains(t, sampleApp.Languages, string(LanguagePython), "sample-app should support python")
 }