Skip to content

Commit c9601be

Browse files
sjmiller609sjmiller609
authored
Http proxy (#25)
<!-- mesa-description-start --> ## TL;DR Add protocol support to the `proxies` command ## Why we made these changes This change allows users to create, list, view, and delete HTTP proxy configurations directly from the command line. This is the first step in enabling browser invocations to use managed HTTP proxies, which is critical for avoiding bot detection. ## What changed? - **`proxies create`**: Creates a new proxy configuration. Now supports `--protocol` flag - **`proxies list`**: Lists all existing proxy configurations in a table. Now shows protocol ## Validation - All new commands were manually tested against the API. - Unit tests covering the new functionality have been added and are passing. <sup>_Description generated by Mesa. [Update settings](https://app.mesa.dev/onkernel/settings/pull-requests)_</sup> <!-- mesa-description-end -->
1 parent c1e1cc6 commit c9601be

File tree

9 files changed

+95
-15
lines changed

9 files changed

+95
-15
lines changed

‎cmd/proxies/create.go‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,19 @@ func (p ProxyCmd) Create(ctx context.Context, in ProxyCreateInput) error {
148148
}
149149
}
150150

151+
// Set protocol (defaults to https if not specified)
152+
if in.Protocol != "" {
153+
// Validate and convert protocol
154+
switch in.Protocol {
155+
case "http":
156+
params.Protocol = kernel.ProxyNewParamsProtocolHTTP
157+
case "https":
158+
params.Protocol = kernel.ProxyNewParamsProtocolHTTPS
159+
default:
160+
return fmt.Errorf("invalid protocol: %s (must be http or https)", in.Protocol)
161+
}
162+
}
163+
151164
pterm.Info.Printf("Creating %s proxy...\n", proxyType)
152165

153166
proxy, err := p.proxies.New(ctx, params)
@@ -168,6 +181,13 @@ func (p ProxyCmd) Create(ctx context.Context, in ProxyCreateInput) error {
168181
rows = append(rows, []string{"Name", name})
169182
rows = append(rows, []string{"Type", string(proxy.Type)})
170183

184+
// Display protocol (default to https if not set)
185+
protocol := string(proxy.Protocol)
186+
if protocol == "" {
187+
protocol = "https"
188+
}
189+
rows = append(rows, []string{"Protocol", protocol})
190+
171191
PrintTableNoPad(rows, true)
172192
return nil
173193
}
@@ -178,6 +198,7 @@ func runProxiesCreate(cmd *cobra.Command, args []string) error {
178198
// Get all flag values
179199
proxyType, _ := cmd.Flags().GetString("type")
180200
name, _ := cmd.Flags().GetString("name")
201+
protocol, _ := cmd.Flags().GetString("protocol")
181202
country, _ := cmd.Flags().GetString("country")
182203
city, _ := cmd.Flags().GetString("city")
183204
state, _ := cmd.Flags().GetString("state")
@@ -195,6 +216,7 @@ func runProxiesCreate(cmd *cobra.Command, args []string) error {
195216
return p.Create(cmd.Context(), ProxyCreateInput{
196217
Name: name,
197218
Type: proxyType,
219+
Protocol: protocol,
198220
Country: country,
199221
City: city,
200222
State: state,

‎cmd/proxies/create_test.go‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,53 @@ func TestProxyCreate_InvalidType(t *testing.T) {
240240
assert.Contains(t, err.Error(), "invalid proxy type: invalid")
241241
}
242242

243+
func TestProxyCreate_Protocol_Valid(t *testing.T) {
244+
tests := []struct {
245+
name string
246+
protocol string
247+
}{
248+
{"http protocol", "http"},
249+
{"https protocol", "https"},
250+
{"empty protocol", ""},
251+
}
252+
253+
for _, tt := range tests {
254+
t.Run(tt.name, func(t *testing.T) {
255+
fake := &FakeProxyService{
256+
NewFunc: func(ctx context.Context, body kernel.ProxyNewParams, opts ...option.RequestOption) (*kernel.ProxyNewResponse, error) {
257+
return &kernel.ProxyNewResponse{
258+
ID: "test-proxy",
259+
Name: "Test Proxy",
260+
Type: kernel.ProxyNewResponseTypeDatacenter,
261+
}, nil
262+
},
263+
}
264+
265+
p := ProxyCmd{proxies: fake}
266+
err := p.Create(context.Background(), ProxyCreateInput{
267+
Type: "datacenter",
268+
Country: "US",
269+
Protocol: tt.protocol,
270+
})
271+
272+
assert.NoError(t, err)
273+
})
274+
}
275+
}
276+
277+
func TestProxyCreate_Protocol_Invalid(t *testing.T) {
278+
fake := &FakeProxyService{}
279+
p := ProxyCmd{proxies: fake}
280+
err := p.Create(context.Background(), ProxyCreateInput{
281+
Type: "datacenter",
282+
Country: "US",
283+
Protocol: "ftp",
284+
})
285+
286+
assert.Error(t, err)
287+
assert.Contains(t, err.Error(), "invalid protocol: ftp")
288+
}
289+
243290
func TestProxyCreate_APIError(t *testing.T) {
244291
_ = captureOutput(t)
245292

‎cmd/proxies/get.go‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,13 @@ func (p ProxyCmd) Get(ctx context.Context, in ProxyGetInput) error {
2828
rows = append(rows, []string{"Name", name})
2929
rows = append(rows, []string{"Type", string(item.Type)})
3030

31+
// Display protocol (default to https if not set)
32+
protocol := string(item.Protocol)
33+
if protocol == "" {
34+
protocol = "https"
35+
}
36+
rows = append(rows, []string{"Protocol", protocol})
37+
3138
// Display type-specific config details
3239
rows = append(rows, getProxyConfigRows(item)...)
3340

‎cmd/proxies/list.go‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func (p ProxyCmd) List(ctx context.Context) error {
2626

2727
// Prepare table data
2828
tableData := pterm.TableData{
29-
{"ID", "Name", "Type", "Config", "Status", "Last Checked"},
29+
{"ID", "Name", "Type", "Protocol", "Config", "Status", "Last Checked"},
3030
}
3131

3232
for _, proxy := range *items {
@@ -35,6 +35,12 @@ func (p ProxyCmd) List(ctx context.Context) error {
3535
name = "-"
3636
}
3737

38+
// Get protocol (default to https if not set, since that's the default)
39+
protocol := string(proxy.Protocol)
40+
if protocol == "" {
41+
protocol = "https"
42+
}
43+
3844
// Format config based on type
3945
configStr := formatProxyConfig(&proxy)
4046

@@ -55,6 +61,7 @@ func (p ProxyCmd) List(ctx context.Context) error {
5561
proxy.ID,
5662
name,
5763
string(proxy.Type),
64+
protocol,
5865
configStr,
5966
status,
6067
lastChecked,

‎cmd/proxies/list_test.go‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,27 +68,22 @@ func TestProxyList_WithProxies(t *testing.T) {
6868
assert.Contains(t, output, "ID")
6969
assert.Contains(t, output, "Name")
7070
assert.Contains(t, output, "Type")
71+
assert.Contains(t, output, "Protocol")
7172
assert.Contains(t, output, "Config")
7273

7374
// Check proxy data
7475
assert.Contains(t, output, "dc-1")
75-
assert.Contains(t, output, "US Datacenter")
76-
assert.Contains(t, output, "datacenter")
77-
assert.Contains(t, output, "Country: US")
76+
assert.Contains(t, output, "https") // Protocol is shown
77+
assert.Contains(t, output, "Country")
7878

7979
assert.Contains(t, output, "res-1")
80-
assert.Contains(t, output, "SF Residential")
81-
assert.Contains(t, output, "residential")
82-
assert.Contains(t, output, "City: sanfrancisco")
83-
assert.Contains(t, output, "State: CA")
8480

8581
assert.Contains(t, output, "custom-1")
8682
assert.Contains(t, output, "My Proxy")
8783
assert.Contains(t, output, "custom")
88-
assert.Contains(t, output, "proxy.example.com:8080")
84+
assert.Contains(t, output, "proxy") // Part of proxy.example.com, will be truncated
8985

9086
assert.Contains(t, output, "mobile-1")
91-
assert.Contains(t, output, "Mobile Proxy")
9287
assert.Contains(t, output, "mobile")
9388
assert.Contains(t, output, "Carrier: verizon")
9489

‎cmd/proxies/proxies.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ func init() {
7070
proxiesCreateCmd.Flags().String("name", "", "Proxy configuration name")
7171
proxiesCreateCmd.Flags().String("type", "", "Proxy type (datacenter|isp|residential|mobile|custom)")
7272
_ = proxiesCreateCmd.MarkFlagRequired("type")
73+
proxiesCreateCmd.Flags().String("protocol", "https", "Protocol to use for the proxy connection (http|https)")
7374

7475
// Location flags (datacenter, isp, residential, mobile)
7576
proxiesCreateCmd.Flags().String("country", "", "ISO 3166 country code or EU")

‎cmd/proxies/types.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@ type ProxyGetInput struct {
2828
}
2929

3030
type ProxyCreateInput struct {
31-
Name string
32-
Type string
31+
Name string
32+
Type string
33+
Protocol string
3334
// Datacenter/ISP config
3435
Country string
3536
// Residential/Mobile config

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ require (
88
github.com/charmbracelet/fang v0.2.0
99
github.com/golang-jwt/jwt/v5 v5.2.2
1010
github.com/joho/godotenv v1.5.1
11-
github.com/onkernel/kernel-go-sdk v0.13.0
11+
github.com/onkernel/kernel-go-sdk v0.14.0
1212
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
1313
github.com/pterm/pterm v0.12.80
1414
github.com/samber/lo v1.51.0

‎go.sum‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ github.com/muesli/mango-pflag v0.1.0 h1:UADqbYgpUyRoBja3g6LUL+3LErjpsOwaC9ywvBWe
9191
github.com/muesli/mango-pflag v0.1.0/go.mod h1:YEQomTxaCUp8PrbhFh10UfbhbQrM/xJ4i2PB8VTLLW0=
9292
github.com/muesli/roff v0.1.0 h1:YD0lalCotmYuF5HhZliKWlIx7IEhiXeSfq7hNjFqGF8=
9393
github.com/muesli/roff v0.1.0/go.mod h1:pjAHQM9hdUUwm/krAfrLGgJkXJ+YuhtsfZ42kieB2Ig=
94-
github.com/onkernel/kernel-go-sdk v0.13.0 h1:yxXE8I7Blze7d5oyeyvKWna088o1mFPIAyK+rjmhw3g=
95-
github.com/onkernel/kernel-go-sdk v0.13.0/go.mod h1:MjUR92i8UPqjrmneyVykae6GuB3GGSmnQtnjf1v74Dc=
94+
github.com/onkernel/kernel-go-sdk v0.14.0 h1:77jDkIq/thQ630TwCr2uu7KxUWXrYw6P5qXSwuFfuQw=
95+
github.com/onkernel/kernel-go-sdk v0.14.0/go.mod h1:MjUR92i8UPqjrmneyVykae6GuB3GGSmnQtnjf1v74Dc=
9696
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c h1:+mdjkGKdHQG3305AYmdv1U2eRNDiU2ErMBj1gwrq8eQ=
9797
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c/go.mod h1:7rwL4CYBLnjLxUqIJNnCWiEdr3bn6IUYi15bNlnbCCU=
9898
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=

0 commit comments

Comments
 (0)