Skip to content

Conversation

@hiroTamada
Copy link
Contributor

@hiroTamada hiroTamada commented Sep 29, 2025

PR Description:

Summary

This PR enhances the kernel invoke history command by adding support for displaying and filtering invocations by version.

Changes

  • Added a "Version" column to the invocation history table output
  • Added --version flag to filter invocations by version
  • Updated kernel-go-sdk dependency from v0.11.4 to v0.11.5

New Features

  1. Version Column: The invocation history table now displays the version of each invocation between the "Action" and "Status" columns
  2. Version Filtering: Users can now filter invocations by version using the --version flag

Usage Examples

# Show all invocations with version column
kernel invoke history

# Filter by version only
kernel invoke history --version v1.2.3

# Filter by app name only  
kernel invoke history --app myapp

# Filter by both app name and version
kernel invoke history --app myapp --version v1.2.3

Implementation Details

  • Leverages the existing Version field from the SDK's InvocationListResponse struct
  • Uses the SDK's Version filter parameter in InvocationListParams
  • Maintains backward compatibility with existing usage patterns
  • Updates debug messages to reflect active filters

Dependencies

  • Updated github.com/onkernel/kernel-go-sdk from v0.11.4 to v0.11.5
image

TL;DR

This PR enhances the kernel invoke history command by adding a "Version" column to the output and a --version flag for filtering.

Why we made these changes

To allow users to easily find and inspect invocations for a specific application version, which is useful for debugging and tracking behavior across different releases.

What changed?

  • cmd/invoke.go: Added the --version flag for filtering and a "Version" column to the history table display.
  • go.mod & go.sum: Updated the github.com/onkernel/kernel-go-sdk dependency from v0.11.4 to v0.11.5 to support the new API parameter.

Validation

The changes were validated by running the command with different flag combinations:

  • kernel invoke history displays the new "Version" column.
  • kernel invoke history --version v1.2.3 correctly filters the results.
  • kernel invoke history --app myapp --version v1.2.3 filters by both app and version.
image

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of e796437...06e4e20

Analysis

Based on the provided analysis, there don't appear to be any significant architectural issues with this pull request. The analysis is entirely positive, noting that the implementation follows established patterns, properly integrates with the SDK, provides a good user experience, and maintains backward compatibility.

Since you specifically asked for potential issues and the analysis doesn't mention any concerns, I can only infer some potential minor considerations:

  1. The addition of a new column (Version) between existing columns (Action and Status) might require UI/display adjustments to ensure proper formatting across different terminal sizes.
  2. The implementation relies on the kernel-go-sdk v0.11.5, which might create a dependency on specific SDK behaviors that could change in future versions.

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

3 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

Copy link
Contributor

@masnwilliams masnwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiroTamada hiroTamada merged commit 86424ea into main Sep 29, 2025
2 checks passed
@hiroTamada hiroTamada deleted the hiro/attach_version_to_invocation_history branch September 29, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants