Skip to content

Conversation

@hiroTamada
Copy link
Contributor

No description provided.

@hiroTamada hiroTamada requested review from Sayan-, masnwilliams and rgarcia and removed request for Sayan- and rgarcia October 16, 2025 17:55
@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Oct 16, 2025

Mesa Description

This PR introduces a kiosk mode for creating new browsers.

  • Adds a --kiosk flag to the browsers create command.
  • When used, this flag launches the browser in a full-screen kiosk mode.
  • Updates Go module dependencies.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 09b6ba1...654e5ca

Analysis

  1. The PR lacks test coverage for the new kiosk mode feature, making it difficult to ensure correct behavior and prevent regressions.

  2. The implementation relies on an upgrade from a pre-release SDK version to a stable release, but there's no explicit documentation on what changes in the SDK were necessary to support this feature.

  3. While the PR follows existing patterns for boolean flags, it doesn't address potential interactions or conflicts between kiosk mode and other browser modes (like stealth or headless).

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

3 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

Copy link
Contributor

@rgarcia rgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good--also update the readme!

@hiroTamada hiroTamada merged commit d107fa0 into main Oct 17, 2025
1 check passed
@hiroTamada hiroTamada deleted the hiro/kiosk_mode branch October 17, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants