Skip to content

Conversation

@mateoCuervo
Copy link
Contributor

@mateoCuervo mateoCuervo commented Nov 12, 2025

Description

This PR adds a new browsers computer set-cursor command to the CLI that allows users to show or hide the mouse cursor in browser computer sessions. This is useful for automations where cursor visibility may interfere with the user experience or for recording purposes. The implementation includes a new SetCursorVisibility method in the BrowserComputerService interface, proper error handling for invalid inputs and non-existent browsers, and updates the kernel-go-sdk from v0.18.0 to v0.19.0 to support the new API endpoint.

Tested

Tested locally it toggles cursor visibility terminal output is
image

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Nov 12, 2025

Mesa Description

Description

This PR adds a new browsers computer set-cursor command to the CLI that allows users to show or hide the mouse cursor in browser computer sessions. This is useful for automations where cursor visibility may interfere with the user experience or for recording purposes. The implementation includes a new SetCursorVisibility method in the BrowserComputerService interface, proper error handling for invalid inputs and non-existent browsers, and updates the kernel-go-sdk from v0.18.0 to v0.19.0 to support the new API endpoint.

Tested

Tested locally it toggles cursor visibility terminal output is
image

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 29988ae...6f5dc3b

Analysis

  1. Flag Design Anti-Pattern: The --hidden flag uses String type requiring explicit true/false values, inconsistent with the codebase's Bool flag pattern, creating unnecessary complexity with manual string parsing and reducing UX quality.

  2. Error Handling Gap: Silent error suppression on flag retrieval could lead to confusing user-facing errors.

  3. API Contract Verification: Response from SetCursorVisibility is discarded without verification of its contents, potentially losing important status or metadata.

  4. Missing Test Coverage: No tests were added for the new functionality, breaking the established pattern where other computer commands have corresponding test files.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

3 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@mateoCuervo mateoCuervo requested a review from rgarcia November 12, 2025 21:54
@mateoCuervo mateoCuervo merged commit 5abf789 into main Nov 13, 2025
2 checks passed
@mateoCuervo mateoCuervo deleted the feat/set-cursor-visibility branch November 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants