feat allow to include deleted browser with pagination #38
Conversation
Mesa DescriptionThis PR introduces the functionality to include deleted browsers in list results, complete with pagination support. A new Description generated by Mesa. Update settings |
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of c27e844...4d8d534
Analysis
-
Missing Input Validation: CLI accepts pagination parameters (limit and offset) without validation, potentially allowing invalid values that could cause backend errors instead of being caught early on the client side.
-
Inconsistent User Messaging: The "No running or persistent browsers found" message doesn't account for when the
--include-deletedflag is active, which could confuse users looking for deleted browsers. -
Helper Method Limitations: Methods like
resolveBrowserByIdentifierdon't consider deleted browsers, which may cause confusion when users attempt to reference deleted browsers by ID in certain contexts.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
4 files reviewed | 0 comments | Edit Agent Settings • Read Docs
There was a problem hiding this comment.
Performed full review of c27e844...4d8d534
Analysis
-
Input Validation Missing: The
--limitflag has a documented maximum of 100, but there's no client-side validation to enforce this constraint, potentially causing unexpected API behavior. -
Incomplete Pagination UX: The CLI doesn't provide information about total results or whether more pages exist, making it difficult for users to navigate through paginated results.
-
Default Behavior Change: Users may not realize they're only seeing the first page (likely 20 items) instead of all browsers, which could be perceived as a breaking change.
-
Limited Error Handling: While basic SDK errors are handled, pagination-specific errors (like invalid offset) lack specific error messages.
-
Testing Gaps: No specific tests validate the pagination logic or verify the correct rendering of the "Deleted At" column.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
4 files reviewed | 0 comments | Edit Agent Settings • Read Docs
Description
Upgrades kernel-go-sdk to v0.20.0 and adds support for viewing soft-deleted browser sessions via the new --include-deleted flag, which displays a Deleted At column in the output when enabled. Also adds --limit and --offset flags to the browsers list command for pagination support, and updates all code and tests to work with the SDK's new pagination-based API that returns OffsetPagination[BrowserListResponse] instead of simple arrays.
Tested
Browsers list still works compatible with past changes
We can paginate
We can now include deleted browsers in results
We can paginate including deleted browsers: