refactor: update browser cleanup method usage

masnwilliams · masnwilliams · commit b70c415cb886 · 2025-12-01T14:55:02.000-05:00
diff --git a/templates/python/sample-app/main.py b/templates/python/sample-app/main.py
@@ -62,7 +62,7 @@ async def get_page_title(ctx: kernel.KernelContext, input_data: PageTitleInput)
             
             return {"title": title}
         finally:
-            await browser.close()
+            client.browsers.delete_by_id(kernel_browser.session_id)
 
 
 """
diff --git a/templates/typescript/sample-app/index.ts b/templates/typescript/sample-app/index.ts
@@ -70,7 +70,7 @@ app.action<PageTitleInput, PageTitleOutput>(
       const title = await page.title();
       return { title };
     } finally {
-      await browser.close();
+      await kernel.browsers.deleteByID(kernelBrowser.session_id);
     }
   }
 );
@@ -90,7 +90,7 @@ app.action<PageTitleInput, PageTitleOutput>(
  *  kernel logs ts-basic -f # Open in separate tab
  */
 interface CreateBrowserForTestingOutput {
-  browser_live_view_url?: string;
+  browser_live_view_url: string;
 }
 app.action(
   "create-browser-for-testing",

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ app.action<PageTitleInput, PageTitleOutput>(`
`70`	`70`	`const title = await page.title();`
`71`	`71`	`return { title };`
`72`	`72`	`} finally {`
`73`		`- await browser.close();`
	`73`	`+ await kernel.browsers.deleteByID(kernelBrowser.session_id);`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`);`
`@@ -90,7 +90,7 @@ app.action<PageTitleInput, PageTitleOutput>(`
`90`	`90`	`* kernel logs ts-basic -f # Open in separate tab`
`91`	`91`	`*/`
`92`	`92`	`interface CreateBrowserForTestingOutput {`
`93`		`- browser_live_view_url?: string;`
	`93`	`+ browser_live_view_url: string;`
`94`	`94`	`}`
`95`	`95`	`app.action(`
`96`	`96`	`"create-browser-for-testing",`