Skip to content

Commit 812e009

Browse files
fix: fix for default flag values
1 parent 3e740a9 commit 812e009

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

internal/requestflag/requestflag.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ type requestValue[T any | string | int64 | float64 | bool] struct {
5858
config RequestConfig
5959
}
6060

61+
func Value[T any | string | int64 | float64 | bool](val T) requestValue[T] {
62+
return requestValue[T]{val, RequestConfig{}}
63+
}
64+
6165
func (s requestValue[T]) RequestConfig() RequestConfig {
6266
return s.config
6367
}
@@ -93,7 +97,7 @@ type requestValueCreator[T any | string | int64 | float64 | bool] struct {
9397
}
9498

9599
func (s requestValueCreator[T]) Create(defaultValue requestValue[T], p *requestValue[T], c RequestConfig) cli.Value {
96-
*p = defaultValue
100+
p.value = defaultValue.value
97101
p.config = c
98102
return &requestValueCreator[T]{
99103
destination: p,

pkg/cmd/instance.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ var instancesCreate = cli.Command{
4242
&requestflag.StringFlag{
4343
Name: "hotplug-size",
4444
Usage: `Additional memory for hotplug (human-readable format like "3GB", "1G")`,
45-
Value: "3GB",
45+
Value: requestflag.Value[string]("3GB"),
4646
Config: requestflag.RequestConfig{
4747
BodyPath: "hotplug_size",
4848
},
@@ -57,23 +57,23 @@ var instancesCreate = cli.Command{
5757
&requestflag.StringFlag{
5858
Name: "overlay-size",
5959
Usage: `Writable overlay disk size (human-readable format like "10GB", "50G")`,
60-
Value: "10GB",
60+
Value: requestflag.Value[string]("10GB"),
6161
Config: requestflag.RequestConfig{
6262
BodyPath: "overlay_size",
6363
},
6464
},
6565
&requestflag.StringFlag{
6666
Name: "size",
6767
Usage: `Base memory size (human-readable format like "1GB", "512MB", "2G")`,
68-
Value: "1GB",
68+
Value: requestflag.Value[string]("1GB"),
6969
Config: requestflag.RequestConfig{
7070
BodyPath: "size",
7171
},
7272
},
7373
&requestflag.IntFlag{
7474
Name: "vcpus",
7575
Usage: "Number of virtual CPUs",
76-
Value: 2,
76+
Value: requestflag.Value[int64](2),
7777
Config: requestflag.RequestConfig{
7878
BodyPath: "vcpus",
7979
},
@@ -139,7 +139,7 @@ var instancesLogs = cli.Command{
139139
&requestflag.IntFlag{
140140
Name: "tail",
141141
Usage: "Number of lines to return from end",
142-
Value: 100,
142+
Value: requestflag.Value[int64](100),
143143
Config: requestflag.RequestConfig{
144144
QueryPath: "tail",
145145
},

0 commit comments

Comments
 (0)