Skip to content

Commit 05fa5a4

Browse files
author
Rafael Garcia
committed
system: use context loggers in initrd building
Replace fmt.Printf calls with proper context loggers so messages appear in structured logs with consistent formatting.
1 parent 8d610e9 commit 05fa5a4

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

lib/system/initrd.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"time"
1616

1717
"github.com/onkernel/hypeman/lib/images"
18+
"github.com/onkernel/hypeman/lib/logger"
1819
)
1920

2021
const alpineBaseImage = "alpine:3.22"
@@ -62,7 +63,8 @@ func (m *manager) buildInitrd(ctx context.Context, arch string) (string, error)
6263
// Add NVIDIA kernel modules (for GPU passthrough support)
6364
if err := m.addNvidiaModules(ctx, rootfsDir, arch); err != nil {
6465
// Log but don't fail - NVIDIA modules are optional (not available on all architectures)
65-
fmt.Printf("initrd: skipping NVIDIA modules: %v\n", err)
66+
log := logger.FromContext(ctx)
67+
log.InfoContext(ctx, "skipping NVIDIA modules", "error", err)
6668
}
6769

6870
// Write generated init script
@@ -205,7 +207,8 @@ func (m *manager) addNvidiaModules(ctx context.Context, rootfsDir, arch string)
205207
// Add userspace driver libraries (libcuda.so, libnvidia-ml.so, nvidia-smi, etc.)
206208
// These are injected into containers at boot time - see lib/devices/GPU.md
207209
if err := m.addNvidiaDriverLibs(ctx, rootfsDir, arch); err != nil {
208-
fmt.Printf("initrd: warning: could not add nvidia driver libs: %v\n", err)
210+
log := logger.FromContext(ctx)
211+
log.WarnContext(ctx, "could not add nvidia driver libs", "error", err)
209212
// Don't fail - kernel modules can still work, but containers won't have driver libs
210213
}
211214

@@ -252,7 +255,8 @@ func (m *manager) addNvidiaDriverLibs(ctx context.Context, rootfsDir, arch strin
252255
return fmt.Errorf("extract nvidia driver libs: %w", err)
253256
}
254257

255-
fmt.Printf("initrd: added NVIDIA driver libraries from %s\n", url)
258+
log := logger.FromContext(ctx)
259+
log.InfoContext(ctx, "added NVIDIA driver libraries", "url", url)
256260
return nil
257261
}
258262

0 commit comments

Comments
 (0)