|
| 1 | +package api |
| 2 | + |
| 3 | +import ( |
| 4 | + "bytes" |
| 5 | + "os" |
| 6 | + "testing" |
| 7 | + "time" |
| 8 | + |
| 9 | + "github.com/onkernel/hypeman/lib/oapi" |
| 10 | + "github.com/onkernel/hypeman/lib/system" |
| 11 | + "github.com/stretchr/testify/assert" |
| 12 | + "github.com/stretchr/testify/require" |
| 13 | +) |
| 14 | + |
| 15 | +func TestExecInstanceNonTTY(t *testing.T) { |
| 16 | + // Require KVM access for VM creation |
| 17 | + if _, err := os.Stat("/dev/kvm"); os.IsNotExist(err) { |
| 18 | + t.Fatal("/dev/kvm not available - ensure KVM is enabled and user is in 'kvm' group (sudo usermod -aG kvm $USER)") |
| 19 | + } |
| 20 | + |
| 21 | + if testing.Short() { |
| 22 | + t.Skip("Skipping integration test in short mode") |
| 23 | + } |
| 24 | + |
| 25 | + svc := newTestService(t) |
| 26 | + |
| 27 | + // First, create and wait for the image to be ready |
| 28 | + t.Log("Creating alpine image...") |
| 29 | + imgResp, err := svc.CreateImage(ctx(), oapi.CreateImageRequestObject{ |
| 30 | + Body: &oapi.CreateImageRequest{ |
| 31 | + Name: "docker.io/library/alpine:latest", |
| 32 | + }, |
| 33 | + }) |
| 34 | + require.NoError(t, err) |
| 35 | + imgCreated, ok := imgResp.(oapi.CreateImage202JSONResponse) |
| 36 | + require.True(t, ok, "expected 202 response") |
| 37 | + assert.Equal(t, "docker.io/library/alpine:latest", imgCreated.Name) |
| 38 | + |
| 39 | + // Wait for image to be ready (poll with timeout) |
| 40 | + t.Log("Waiting for image to be ready...") |
| 41 | + timeout := time.After(120 * time.Second) |
| 42 | + ticker := time.NewTicker(2 * time.Second) |
| 43 | + defer ticker.Stop() |
| 44 | + |
| 45 | + imageReady := false |
| 46 | + for !imageReady { |
| 47 | + select { |
| 48 | + case <-timeout: |
| 49 | + t.Fatal("Timeout waiting for image to be ready") |
| 50 | + case <-ticker.C: |
| 51 | + imgResp, err := svc.GetImage(ctx(), oapi.GetImageRequestObject{ |
| 52 | + Name: "docker.io/library/alpine:latest", |
| 53 | + }) |
| 54 | + require.NoError(t, err) |
| 55 | + |
| 56 | + img, ok := imgResp.(oapi.GetImage200JSONResponse) |
| 57 | + if ok && img.Status == "ready" { |
| 58 | + imageReady = true |
| 59 | + t.Log("Image is ready") |
| 60 | + } else if ok { |
| 61 | + t.Logf("Image status: %s", img.Status) |
| 62 | + } |
| 63 | + } |
| 64 | + } |
| 65 | + |
| 66 | + // Create instance |
| 67 | + t.Log("Creating instance...") |
| 68 | + instResp, err := svc.CreateInstance(ctx(), oapi.CreateInstanceRequestObject{ |
| 69 | + Body: &oapi.CreateInstanceRequest{ |
| 70 | + Name: "exec-test", |
| 71 | + Image: "docker.io/library/alpine:latest", |
| 72 | + }, |
| 73 | + }) |
| 74 | + require.NoError(t, err) |
| 75 | + |
| 76 | + inst, ok := instResp.(oapi.CreateInstance201JSONResponse) |
| 77 | + require.True(t, ok, "expected 201 response") |
| 78 | + require.NotEmpty(t, inst.Id) |
| 79 | + t.Logf("Instance created: %s", inst.Id) |
| 80 | + |
| 81 | + // Wait a bit for instance to fully boot |
| 82 | + time.Sleep(5 * time.Second) |
| 83 | + |
| 84 | + // Get actual instance to access vsock fields |
| 85 | + actualInst, err := svc.InstanceManager.GetInstance(ctx(), inst.Id) |
| 86 | + require.NoError(t, err) |
| 87 | + require.NotNil(t, actualInst) |
| 88 | + |
| 89 | + // Verify vsock fields are set |
| 90 | + require.Greater(t, actualInst.VsockCID, int64(2), "vsock CID should be > 2 (reserved values)") |
| 91 | + require.NotEmpty(t, actualInst.VsockSocket, "vsock socket path should be set") |
| 92 | + t.Logf("vsock CID: %d, socket: %s", actualInst.VsockCID, actualInst.VsockSocket) |
| 93 | + |
| 94 | + // Test exec with a simple command |
| 95 | + t.Log("Testing exec command: whoami") |
| 96 | + exit, err := system.ExecIntoInstance(ctx(), uint32(actualInst.VsockCID), system.ExecOptions{ |
| 97 | + Command: []string{"/bin/sh", "-c", "whoami"}, |
| 98 | + Stdin: nil, |
| 99 | + Stdout: &outputBuffer{}, |
| 100 | + Stderr: &outputBuffer{}, |
| 101 | + TTY: false, |
| 102 | + }) |
| 103 | + |
| 104 | + if err != nil { |
| 105 | + t.Logf("Exec failed (expected if agent not fully ready): %v", err) |
| 106 | + // This is acceptable - the agent might not be fully initialized yet |
| 107 | + } else { |
| 108 | + t.Logf("Exec succeeded with exit code: %d", exit.Code) |
| 109 | + assert.Equal(t, 0, exit.Code, "whoami should succeed with exit code 0") |
| 110 | + } |
| 111 | + |
| 112 | + // Cleanup |
| 113 | + t.Log("Cleaning up instance...") |
| 114 | + delResp, err := svc.DeleteInstance(ctx(), oapi.DeleteInstanceRequestObject{ |
| 115 | + Id: inst.Id, |
| 116 | + }) |
| 117 | + require.NoError(t, err) |
| 118 | + _, ok = delResp.(oapi.DeleteInstance204Response) |
| 119 | + require.True(t, ok, "expected 204 response") |
| 120 | +} |
| 121 | + |
| 122 | +// outputBuffer is a simple buffer for capturing exec output |
| 123 | +type outputBuffer struct { |
| 124 | + buf bytes.Buffer |
| 125 | +} |
| 126 | + |
| 127 | +func (b *outputBuffer) Write(p []byte) (n int, err error) { |
| 128 | + return b.buf.Write(p) |
| 129 | +} |
| 130 | + |
| 131 | +func (b *outputBuffer) String() string { |
| 132 | + return b.buf.String() |
| 133 | +} |
| 134 | + |
| 135 | +// TestVsockCIDGeneration tests the vsock CID generation logic |
| 136 | +func TestVsockCIDGeneration(t *testing.T) { |
| 137 | + testCases := []struct { |
| 138 | + id string |
| 139 | + expectedMin int64 |
| 140 | + expectedMax int64 |
| 141 | + }{ |
| 142 | + {"abc123", 3, 4294967294}, |
| 143 | + {"xyz789", 3, 4294967294}, |
| 144 | + {"test-id-here", 3, 4294967294}, |
| 145 | + {"a", 3, 4294967294}, |
| 146 | + {"verylonginstanceid12345", 3, 4294967294}, |
| 147 | + } |
| 148 | + |
| 149 | + for _, tc := range testCases { |
| 150 | + t.Run(tc.id, func(t *testing.T) { |
| 151 | + cid := generateVsockCID(tc.id) |
| 152 | + require.GreaterOrEqual(t, cid, tc.expectedMin, "CID must be >= 3") |
| 153 | + require.LessOrEqual(t, cid, tc.expectedMax, "CID must be < 2^32-1") |
| 154 | + }) |
| 155 | + } |
| 156 | + |
| 157 | + // Test consistency - same ID should always produce same CID |
| 158 | + cid1 := generateVsockCID("consistent-test") |
| 159 | + cid2 := generateVsockCID("consistent-test") |
| 160 | + require.Equal(t, cid1, cid2, "Same instance ID should produce same CID") |
| 161 | +} |
| 162 | + |
| 163 | +// generateVsockCID is re-declared here for testing |
| 164 | +func generateVsockCID(instanceID string) int64 { |
| 165 | + idPrefix := instanceID |
| 166 | + if len(idPrefix) > 8 { |
| 167 | + idPrefix = idPrefix[:8] |
| 168 | + } |
| 169 | + |
| 170 | + var sum int64 |
| 171 | + for _, c := range idPrefix { |
| 172 | + sum = sum*37 + int64(c) |
| 173 | + } |
| 174 | + |
| 175 | + return (sum % 4294967292) + 3 |
| 176 | +} |
| 177 | + |
0 commit comments