liveness / reconciliation on startup

Author: Rafael Garcia

cmd/api/main.go

@@ -173,7 +173,12 @@ func run() error {
 	logger.Info("Network manager initialized")
 
 	// Reconcile device state (clears orphaned attachments from crashed VMs)
+	// Set up liveness checker so device reconciliation can accurately detect orphaned attachments
 	logger.Info("Reconciling device state...")
+	livenessChecker := instances.NewLivenessChecker(app.InstanceManager)
+	if livenessChecker != nil {
+		app.DeviceManager.SetLivenessChecker(livenessChecker)
+	}
 	if err := app.DeviceManager.ReconcileDevices(app.Ctx); err != nil {
 		logger.Error("failed to reconcile device state", "error", err)
 		return fmt.Errorf("reconcile device state: %w", err)

lib/devices/gpu_e2e_test.go

@@ -249,7 +249,7 @@ func TestGPUPassthrough(t *testing.T) {
 	if execErr != nil {
 		// Print console log for debugging
 		p := paths.New(tmpDir)
-		consoleLogPath := p.InstanceConsoleLog(inst.Id)
+		consoleLogPath := p.InstanceAppLog(inst.Id)
 		if consoleLog, err := os.ReadFile(consoleLogPath); err == nil {
 			t.Logf("=== VM Console Log ===\n%s\n=== End Console Log ===", string(consoleLog))
 		} else {

lib/devices/gpu_inference_test.go

@@ -400,7 +400,7 @@ func TestGPUInference(t *testing.T) {
 
 	if err != nil {
 		// Log console for debugging
-		consoleLogPath := p.InstanceConsoleLog(inst.Id)
+		consoleLogPath := p.InstanceAppLog(inst.Id)
 		if consoleLog, readErr := os.ReadFile(consoleLogPath); readErr == nil {
 			t.Logf("=== VM Console Log ===\n%s\n=== End ===", truncateTail(string(consoleLog), 3000))
 		}