Fix docker build failure when buildkit container is absent (#22)

* fix(docker): container presence check failure, extra output

* Apply suggestion from @Sayan- fixing exit when container is stopped

Co-authored-by: Sayan <[email protected]>

* Apply suggestion from @Sayan- propagating conversion of test to if conditional

Co-authored-by: Sayan <[email protected]>

---------

Co-authored-by: Matt Marangoni <[email protected]>
Co-authored-by: Sayan <[email protected]>

Author: matthewjmarangoni

images/chromium-headful/build-docker.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-set -ex -o pipefail
+set -e -o pipefail
 
 # Move to the script's directory so relative paths work regardless of the caller CWD
 SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)

shared/start-buildkit.sh

@@ -6,20 +6,18 @@
 export KRAFTKIT_BUILDKIT_HOST=docker-container://buildkit
 
 # Install container if not already installed.
-docker container inspect buildkit > /dev/null 2>&1
-if test $? -eq 0; then
+if [ -n "$(docker ps --all --no-trunc --quiet --filter 'name=^buildkit$')" ]; then
     echo "Container 'buildkit' is already installed. Nothing to do."
 else
     echo "Installing 'buildkit' container ... "
     docker run -d --name buildkit --privileged moby/buildkit:latest
     return $?
 fi
 
-test "$(docker container inspect -f '{{.State.Running}}' buildkit 2> /dev/null)" = "true"
-if test $? -eq 0; then
-    echo "Container 'buidlkitd' is already running. Nothing to do."
+if [ "$(docker container inspect -f '{{.State.Running}}' buildkit 2> /dev/null)" = "true" ]; then
+    echo "Container 'buildkit' is already running. Nothing to do."
 else
     echo "Starting 'buildkit' container ... "
     docker start buildkit
     return $?
-fi
+fi